[cmake-developers] find_package error wording
Alexander Neundorf
neundorf at kde.org
Fri Feb 17 16:01:47 EST 2012
On Friday 17 February 2012, Brad King wrote:
> On 2/17/2012 2:16 PM, Alexander Neundorf wrote:
> > On Friday 17 February 2012, Brad King wrote:
> >> On 2/17/2012 2:01 PM, Alexander Neundorf wrote:
> >>> Do you want me to add the new keywords ?
> >>> NO_MODULE == CONFIG_MODE == !MODULE == !NO_CONFIG_MODE
> >>
> >> Yes, but I don't think NO_CONFIG_MODE is necessary. NO_MODULE
> >> will become historical. Let's make the new ones consistent with
> >>
> >> each other:
> >> CONFIG_MODE
> >> MODULE_MODE
> >>
> >> The names have clear mapping to the documented modes.
> >>
> >> This change can be made first with documentation and tests.
> >> I'd like to review and accept that change first.
> >
> > I'd like to do this on top of the FindPackage_ImprovedErrorMessages
> > branch, which has IMO only uncontroversial fixes to the error messages
> > and a small bugfix.
> > Ok ?
> > (since I merged this already into next, and I have never undone such a
> > merge yet)
>
> Okay. The messages will be tweaked again by the new modes though.
There is now a branch FindPackage_CONFIG_MODE_MODULE_MODE which has the two
keywords, but doesn't change the behaviour yet.
So there wasn't a lot to change in the documentation or tests.
I'll do the modified behaviour together with the policy.
Alex
More information about the cmake-developers
mailing list