[cmake-developers] Is KWStyle still maintained?

Nicolas Desprès nicolas.despres at gmail.com
Mon Feb 6 10:14:50 EST 2012


2012/2/6 David Cole <david.cole at kitware.com>:
> 2012/2/6 Nicolas Desprès <nicolas.despres at gmail.com>:
>> 2012/2/5 David Cole <david.cole at kitware.com>:
>>> 2012/2/5 Nicolas Desprès <nicolas.despres at gmail.com>:
>>>> Hi,
>>>>
>>>> I have just try to enable KWStyle check in CMake on Mac OS X 10.7.3
>>>> but it crashes.
>>>>
>>>> With the version from the website:
>>>> http://public.kitware.com/KWStyle/download/KWStyle-snapshot-070515.zip
>>>>
>>>> I get this when I run:
>>>> $ make VERBOSE=1 MoreStyleChecks
>>>> /usr/local/Cellar/cmake/2.8.7/bin/cmake -H/Users/polrop/src/cmake
>>>> -B/Users/polrop/src/cmake/_build --check-build-system
>>>> CMakeFiles/Makefile.cmake 0
>>>> make -f CMakeFiles/Makefile2 MoreStyleChecks
>>>> /usr/local/Cellar/cmake/2.8.7/bin/cmake -H/Users/polrop/src/cmake
>>>> -B/Users/polrop/src/cmake/_build --check-build-system
>>>> CMakeFiles/Makefile.cmake 0
>>>> /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_progress_start
>>>> /Users/polrop/src/cmake/_build/CMakeFiles 0
>>>> make -f CMakeFiles/Makefile2
>>>> Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/all
>>>> make -f Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build.make
>>>> Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/depend
>>>> cd /Users/polrop/src/cmake/_build &&
>>>> /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_depends "Unix
>>>> Makefiles" /Users/polrop/src/cmake
>>>> /Users/polrop/src/cmake/Utilities/KWStyle
>>>> /Users/polrop/src/cmake/_build
>>>> /Users/polrop/src/cmake/_build/Utilities/KWStyle
>>>> /Users/polrop/src/cmake/_build/Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/DependInfo.cmake
>>>> --color=
>>>> make -f Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build.make
>>>> Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build
>>>> /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_progress_report
>>>> /Users/polrop/src/cmake/_build/CMakeFiles
>>>> Coding Style Checker, more checks enabled
>>>> cd /Users/polrop/src/cmake/_build/Utilities/KWStyle &&
>>>> /Users/polrop/usr/stow/kwstyle-070515/bin/KWStyle -xml
>>>> /Users/polrop/src/cmake/_build/CMakeMoreChecks.kws.xml -html
>>>> /Users/polrop/src/cmake/_build/html -o
>>>> /Users/polrop/src/cmake/Utilities/KWStyle/CMakeOverwrite.txt -v -D
>>>> /Users/polrop/src/cmake/_build/CMakeKWSFiles.txt
>>>> /bin/sh: line 1: 22504 Floating point exception: 8
>>>> /Users/polrop/usr/stow/kwstyle-070515/bin/KWStyle -xml
>>>> /Users/polrop/src/cmake/_build/CMakeMoreChecks.kws.xml -html
>>>> /Users/polrop/src/cmake/_build/html -o
>>>> /Users/polrop/src/cmake/Utilities/KWStyle/CMakeOverwrite.txt -v -D
>>>> /Users/polrop/src/cmake/_build/CMakeKWSFiles.txt
>>>> make[3]: *** [Utilities/KWStyle/CMakeFiles/MoreStyleChecks] Error 136
>>>> make[2]: *** [Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/all] Error 2
>>>> make[1]: *** [Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/rule] Error 2
>>>> make: *** [MoreStyleChecks] Error 2
>>>>
>>>> With the cvs version: cvs -d
>>>> :pserver:anoncvs at public.kitware.com:/cvsroot/KWStyle co KWStyle
>>>>
>>>> /usr/local/Cellar/cmake/2.8.7/bin/cmake -H/Users/polrop/src/cmake
>>>> -B/Users/polrop/src/cmake/_build --check-build-system
>>>> CMakeFiles/Makefile.cmake 0
>>>> make -f CMakeFiles/Makefile2 MoreStyleChecks
>>>> /usr/local/Cellar/cmake/2.8.7/bin/cmake -H/Users/polrop/src/cmake
>>>> -B/Users/polrop/src/cmake/_build --check-build-system
>>>> CMakeFiles/Makefile.cmake 0
>>>> /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_progress_start
>>>> /Users/polrop/src/cmake/_build/CMakeFiles 0
>>>> make -f CMakeFiles/Makefile2
>>>> Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/all
>>>> make -f Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build.make
>>>> Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/depend
>>>> cd /Users/polrop/src/cmake/_build &&
>>>> /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_depends "Unix
>>>> Makefiles" /Users/polrop/src/cmake
>>>> /Users/polrop/src/cmake/Utilities/KWStyle
>>>> /Users/polrop/src/cmake/_build
>>>> /Users/polrop/src/cmake/_build/Utilities/KWStyle
>>>> /Users/polrop/src/cmake/_build/Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/DependInfo.cmake
>>>> --color=
>>>> make -f Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build.make
>>>> Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/build
>>>> /usr/local/Cellar/cmake/2.8.7/bin/cmake -E cmake_progress_report
>>>> /Users/polrop/src/cmake/_build/CMakeFiles
>>>> Coding Style Checker, more checks enabled
>>>> cd /Users/polrop/src/cmake/_build/Utilities/KWStyle &&
>>>> /Users/polrop/usr/stow/kwstyle-cvs/bin/KWStyle -xml
>>>> /Users/polrop/src/cmake/_build/CMakeMoreChecks.kws.xml -html
>>>> /Users/polrop/src/cmake/_build/html -o
>>>> /Users/polrop/src/cmake/Utilities/KWStyle/CMakeOverwrite.txt -v -D
>>>> /Users/polrop/src/cmake/_build/CMakeKWSFiles.txt
>>>> Processing /Users/polrop/src/cmake/Source/CPack/OSXScriptLauncher.cxx
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackArchiveGenerator.cxx
>>>> Error #30 (50) function (addOneComponentToArchive) doesn't match
>>>> regular expression: ^(cm)?[A-Z]
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackArchiveGenerator.h
>>>> Error #13 (0) Header mismatch: [no char] (,) :
>>>> /Users/polrop/src/cmake/Utilities/KWStyle/Headers
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackBundleGenerator.cxx
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackBundleGenerator.h
>>>> Error #13 (0) Header mismatch: [no char] (,) :
>>>> /Users/polrop/src/cmake/Utilities/KWStyle/Headers
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackComponentGroup.cxx
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackComponentGroup.h
>>>> Error #13 (0) Header mismatch: [no char] (,) :
>>>> /Users/polrop/src/cmake/Utilities/KWStyle/Headers
>>>> Error #2 (57) Internal variable (1) doesn't match regular expression (^[A-Z])
>>>> Error #2 (61) Internal variable (1) doesn't match regular expression (^[A-Z])
>>>> Error #2 (64) Internal variable (1) doesn't match regular expression (^[A-Z])
>>>> Error #2 (68) Internal variable (1) doesn't match regular expression (^[A-Z])
>>>> Error #2 (57) Internal variable (1) doesn't match regular expression (^[A-Z])
>>>> Error #2 (61) Internal variable (1) doesn't match regular expression (^[A-Z])
>>>> Error #2 (64) Internal variable (1) doesn't match regular expression (^[A-Z])
>>>> Error #2 (68) Internal variable (1) doesn't match regular expression (^[A-Z])
>>>> Error #2 (123) Internal variable (1) doesn't match regular expression (^[A-Z])
>>>> Error #2 (126) Internal variable (1) doesn't match regular expression (^[A-Z])
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackConfigure.h.in
>>>> Error #13 (1) The header is incomplete
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackCygwinBinaryGenerator.cxx
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackCygwinBinaryGenerator.h
>>>> Error #13 (0) Header mismatch: [no char] (,) :
>>>> /Users/polrop/src/cmake/Utilities/KWStyle/Headers
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackCygwinSourceGenerator.cxx
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackCygwinSourceGenerator.h
>>>> Error #13 (0) Header mismatch: [no char] (,) :
>>>> /Users/polrop/src/cmake/Utilities/KWStyle/Headers
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackDebGenerator.cxx
>>>> Error #30 (276) function (createDeb) doesn't match regular expression:
>>>> ^(cm)?[A-Z]
>>>> Error #31 (276) function (createDeb) has too many lines: 274 (200)
>>>> Error #30 (680) function (ar_rname) doesn't match regular expression:
>>>> ^(cm)?[A-Z]
>>>> Error #30 (706) function (copy_ar) doesn't match regular expression: ^(cm)?[A-Z]
>>>> Error #30 (738) function (put_arobj) doesn't match regular expression:
>>>> ^(cm)?[A-Z]
>>>> Error #30 (791) function (ar_append) doesn't match regular expression:
>>>> ^(cm)?[A-Z]
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackDebGenerator.h
>>>> Error #13 (0) Header mismatch: [no char] (,) :
>>>> /Users/polrop/src/cmake/Utilities/KWStyle/Headers
>>>> Error #2 (59) Internal variable (packageFiles) doesn't match regular
>>>> expression (^[A-Z])
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackDragNDropGenerator.cxx
>>>> Error #7 (29) Unnecessary semicolon
>>>> Error #7 (48) Unnecessary semicolon
>>>> Error #7 (440) Unnecessary semicolon
>>>> Error #30 (21) function ('LPic') doesn't match regular expression: ^(cm)?[A-Z]
>>>> Error #30 (33) function ('STR#') doesn't match regular expression: ^(cm)?[A-Z]
>>>> Error #30 (426) function ('TEXT') doesn't match regular expression: ^(cm)?[A-Z]
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackDragNDropGenerator.h
>>>> Error #13 (0) Header mismatch: [no char] (,) :
>>>> /Users/polrop/src/cmake/Utilities/KWStyle/Headers
>>>>
>>>>
>>>> Processing /Users/polrop/src/cmake/Source/CPack/cmCPackGenerator.cxx
>>>> terminate called throwing an exception/bin/sh: line 1: 22597 Abort
>>>> trap: 6           /Users/polrop/usr/stow/kwstyle-cvs/bin/KWStyle -xml
>>>> /Users/polrop/src/cmake/_build/CMakeMoreChecks.kws.xml -html
>>>> /Users/polrop/src/cmake/_build/html -o
>>>> /Users/polrop/src/cmake/Utilities/KWStyle/CMakeOverwrite.txt -v -D
>>>> /Users/polrop/src/cmake/_build/CMakeKWSFiles.txt
>>>> make[3]: *** [Utilities/KWStyle/CMakeFiles/MoreStyleChecks] Error 134
>>>> make[2]: *** [Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/all] Error 2
>>>> make[1]: *** [Utilities/KWStyle/CMakeFiles/MoreStyleChecks.dir/rule] Error 2
>>>> make: *** [MoreStyleChecks] Error 2
>>>>
>>>> In both cases it crashes.
>>>>
>>>> Also you can notice that it returns false-positive errors in
>>>> Source/CPack/cmCPackDragNDropGenerator.cxx because all of are in
>>>> strings.
>>>>
>>>> Should we spend effort trying to fix that or should we just removed it?
>>>>
>>>> Cheers,
>>>>
>>>> --
>>>> Nicolas Desprès
>>>> --
>>>>
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
>>>
>>> That's a really really really old snapshot of KWStyle. Its website is
>>> woefully out of date.
>>>
>>> You can get an up to date KWStyle source tree from git these days:
>>>
>>>  http://public.kitware.com/gitweb?p=KWStyle.git;a=summary
>>>
>>
>> Ok thanks for the link.
>>
>> I have tried with the last master of the Git repository and it crashes
>> too on Source/CPack/cmCPackGenerator.cxx:
>>
>> terminate called throwing an exception/bin/sh: line 1:  4549 Abort
>> trap: 6           /Users/polrop/usr/bin/KWStyle -xml
>> /Users/polrop/src/cmake/_build/CMakeMoreChecks.kws.xml -html
>> /Users/polrop/src/cmake/_build/html -o
>> /Users/polrop/src/cmake/Utilities/KWStyle/CMakeOverwrite.txt -v -D
>> /Users/polrop/src/cmake/_build/CMakeKWSFiles.txt
>>
>> and there are still false-positive errors in
>> Source/CPack/cmCPackDragNDropGenerator.cxx:
>>
>> Error #7 (29) Unnecessary semicolon
>> Error #7 (48) Unnecessary semicolon
>> Error #7 (440) Unnecessary semicolon
>> Error #30 (21) function ('LPic') doesn't match regular expression: ^(cm)?[A-Z]
>> Error #30 (33) function ('STR#') doesn't match regular expression: ^(cm)?[A-Z]
>> Error #30 (426) function ('TEXT') doesn't match regular expression: ^(cm)?[A-Z]
>> Error #31 (215) function (CreateDMG) has too many lines: 324 (200)
>>
>> Is there a bug tracker?
>>
>> TIA
>>
>> --
>> Nicolas Desprès
>
>
> I've asked my colleagues who to send this to, and I'll reply again
> when I find out...
>

Thx.

> In the meantime, I just noticed you're attempting to run the
> "MoreStyleChecks" target. We have only enforced the basic style checks
> for the last few years, so I'm not terribly surprised that you would
> run into issues attempting to run MoreStyleChecks. I'm not sure if
> KWStyle has a bug in it, or if the settings we use for the
> MoreStyleCheck target are outdated. Either way, certainly KWStyle
> should not crash.

The profile used by the StyleCheck target is almost empty:

<?xml version="1.0" encoding="iso-8859-1"?>
<Description>
<LineLength>79</LineLength>
<!--
<Header>"/Users/polrop/src/cmake/Utilities/KWStyle/Headers",false,true</Header>
<Functions>
<regex>[A-Z]</regex>
<length>100</length>
</Functions>
-->
</Description>

It basically only check if we do not exceed 79 columns per line.

The one from MoreStyleChecks (CMakeMoreChecks.kws.xml) seems more
strict but you are right it might be out of date. Last "real" update
according to git log was in 2007.

Cheers,

-- 
Nicolas Desprès



More information about the cmake-developers mailing list