[cmake-developers] kwsys requests

[David Cole]

What? You don't like our indentifier? Doesn't help you with all the
indentifying you need to do?

:-P


D



On Fri, Dec 21, 2012 at 9:20 AM, Stephen Kelly <steveire at gmail.com> wrote:

>
> Hi,
>
> As the copy of kwsys is updated from time to time, I have two requests for
> the next update:
>
>  * Make it compile cleanly with -Wundef
>  * Add a MakeCidentifier method to SystemTools
>
> diff --git a/Source/kwsys/SystemTools.cxx b/Source/kwsys/SystemTools.cxx
> index 085d988..a8404b0 100644
> --- a/Source/kwsys/SystemTools.cxx
> +++ b/Source/kwsys/SystemTools.cxx
> @@ -4048,7 +4048,7 @@ kwsys_stl::string
> SystemTools::GetCurrentDateTime(const char* format)
>    return kwsys_stl::string(buf);
>  }
>
> -kwsys_stl::string SystemTools::MakeCindentifier(const char* s)
> +kwsys_stl::string SystemTools::MakeCidentifier(const char* s)
>  {
>    kwsys_stl::string str(s);
>    if (str.find_first_of("0123456789") == 0)
> diff --git a/Source/kwsys/SystemTools.hxx.in
> b/Source/kwsys/SystemTools.hxx.in
> index 5171125..dc09ae5 100644
> --- a/Source/kwsys/SystemTools.hxx.in
> +++ b/Source/kwsys/SystemTools.hxx.in
> @@ -91,8 +91,13 @@ public:
>     * then an underscore is prepended.  Note that this can produce
>     * identifiers that the standard reserves (_[A-Z].* and __.*).
>     */
> -  static kwsys_stl::string MakeCindentifier(const char* s);
> -
> +  static kwsys_stl::string MakeCindentifier(const char* s)
> +  {
> +    return this->MakeCidentifier(s);
> +  }
> +
> +  static kwsys_stl::string MakeCidentifier(const char* s);
> +
>
>
> Thanks,
>
> Steve.
>
>
>
> --
>
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the CMake FAQ at:
> http://www.cmake.org/Wiki/CMake_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20121221/e77cf11e/attachment.html>