[cmake-developers] OpenBSD specific patches

Amit Kulkarni amitkulz at gmail.com
Wed Dec 5 12:38:53 EST 2012


> >> A /usr/local/lib/qt3/bin/moc exists on my machine. I think that the
> >> OpenBSD environment (linker or libtool) takes care of it. David will
> >> confirm here. I notice all the FindQt3 patches are /usr/local.
> >
> > This is an example of why we need commit messages to explain the changes.
> > From reading the patch I have no idea why the path makes sense there.
> 
> OpenBSD allows installs of qt3 and qt4 with a goal of concurrently
> supporting the package builds of kde3 and kde4. So qt3/qt4 are
> installed in appropriate folders under /usr/local. The package
> infrastructure takes care of installing files either under lib/qt3 or
> lib/qt4 (just giving an example of lib, a similar thing happens for
> include, share/doc etc.) relative to a /usr/local.
> 
> Some programs common to both are renamed with either a suffix of 3 or
> 4 to prevent confusion when invoking them. I hope this explanation is
> sufficient for the Qt related patches? I will wait for your okay
> before sending out the Qt related patches tomorrow.
> 
> The current patches were extracted from
> http://www.openbsd.org/cgi-bin/cvsweb/ports/devel/cmake/patches/ by
> David. He refactored stuff which can be pushed upstream to cmake.


Thanks for the commit of the previous messages. 

I just sent a patch for the qt3/qt4 changes. I hope the above explanation is sufficient, if not please email and maybe David can elaborate if needed.

It is a pleasure to deal with ITK/CMake, patches are applied with good feedback.



More information about the cmake-developers mailing list