[cmake-developers] Porting QtDialog to Qt 5

David Cole david.cole at kitware.com
Tue Aug 21 07:20:14 EDT 2012


Looks good to me. (Visual inspection only...)

One thing I noticed about the topic branch, though. You've got two email
addresses listed as commit authors, but they're both you... Did you want to
make those consistent before they go into CMake?


On Tue, Aug 21, 2012 at 5:18 AM, Stephen Kelly <steveire at gmail.com> wrote:

>
> Hi,
>
> I've pushed the qt5-qtdialog-port branch to stage. It makes it possible to
> build the QtDialog with Qt 5 (and some other clean-ups). I don't have Qt 4
> in my Qt 5 environment, and I do need cmake in my Qt 5 environment, so this
> ensures that I get a usable dialog when building cmake in my Qt 5
> environment.
>
> In the branch, Qt 5 is preferred if found.
>
> Any objection to merging it to next?
>
> Thanks,
>
> Steve.
>
>
> --
>
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the CMake FAQ at:
> http://www.cmake.org/Wiki/CMake_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120821/c7579387/attachment.html>


More information about the cmake-developers mailing list