[cmake-developers] Unique compile definitions

David Cole david.cole at kitware.com
Mon Aug 20 14:31:42 EDT 2012


On Mon, Aug 20, 2012 at 12:08 PM, David Cole <david.cole at kitware.com> wrote:

> On Mon, Aug 20, 2012 at 8:52 AM, Stephen Kelly <steveire at gmail.com> wrote:
>
>> David Cole wrote:
>> >> First batch of (unfortunately) *build* errors from Visual Studio:
>> >>
>> >>   http://open.cdash.org/viewBuildError.php?buildid=2525364
>> >>
>> >> c_str and const_iterator issues...
>> >>
>> >> Let me know when you have the next commit on the stage, and I'll pull
>> it
>> >> and try again.
>>
>> I've fixed the issues and force-pushed to stage.
>>
>> Thanks,
>>
>> Steve.
>>
>>
>> --
>>
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Please keep messages on-topic and check the CMake FAQ at:
>> http://www.cmake.org/Wiki/CMake_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
>>
>
>
> Two more builds right now, but with test failures this time. I sort of
> doubt that the test failures have anything to do with your branch. KWStyle
> is failing everywhere, the timing one probably failed because I was running
> a Release and a Debug dashboard at the same time, and the ExernalProject
> test is failing because of a git-related clone issue with the local repo --
> may also be due to running two at the same time.
>
> I'm running them separately now, Release first.
>
> Check out the dashboards for "hut11" -- if they next two come back mostly
> clean (aside from KWStyle) it's probably ready to merge to 'next'
>
> Thx,
> David
>
>

OK -- the KWStyle test failure *is* related to your changes:

Processing C:/Users/davidcole/Dashboards/My
Tests/CMake/Source/cmLocalVisualStudio6Generator.cxx
Error #0 (447) Line length exceed 81 (max=79)


But the ExternalProject test failure still occurs on this machine for this
build even when I back out your changes and go to straight 'nightly-master'
....


So: fix the style problem, and then go ahead and merge it to 'next'.

Unless you also want me to try it out with Visual Studio 6 just for good
measure... :-)


Let me know,
David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120820/7b986506/attachment.html>


More information about the cmake-developers mailing list