[cmake-developers] FindX11 change breaks complex test

Rolf Eike Beer eike at sf-mail.de
Wed Aug 15 17:08:50 EDT 2012


Rolf Eike Beer wrote:
> David Cole wrote:
> > On Wed, Aug 15, 2012 at 1:28 PM, Rolf Eike Beer wrote:

> > > I'll work around this for now, but I wonder if the restriction in
> > > list(REMOVE_DUPLICATES) actually makes sense. We don't give an error if
> > > there are no duplicates, why should we give an error if there are no
> > > items?
> > 
> > Is it that there are no items, or that there is not even a list with that
> > name?
> 
> In line 151 of FindX11.cmake there is a
> 
>   set(X11_LIBRARY_DIR "")
> 
> so the variable should exists.

If anybody (me included) had really read what I was writing ;)

So the real initialization of that list is in line 156, which looks like:

  set(X11_INCLUDE_DIR) # start with empty list

When writing "" to the list it works, I've now added an explicit testcase for 
that.

Eike
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20120815/17f53219/attachment.sig>


More information about the cmake-developers mailing list