[cmake-developers] [PATCH 4/7] Make cmLocalGenerator::ConvertToLinkReference virtual

[Michael Wild]

On 09/27/2011 04:00 PM, Rolf Eike Beer wrote:
>> This provides a mechanism for the local generator to override how
>> library search paths are generated.
>> ---
>>  Source/cmLocalGenerator.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/Source/cmLocalGenerator.h b/Source/cmLocalGenerator.h
>> index 1f5a26e..69e452b 100644
>> --- a/Source/cmLocalGenerator.h
>> +++ b/Source/cmLocalGenerator.h
>> @@ -369,7 +369,7 @@ protected:
>>    std::string FindRelativePathTopBinary();
>>    void SetupPathConversions();
>>
>> -  std::string ConvertToLinkReference(std::string const& lib);
>> +  virtual std::string ConvertToLinkReference(std::string const& lib);
>>
>>    /** Check whether the native build system supports the given
>>        definition.  Issues a warning.  */
> 
> You have not changed this, but I wonder why this function is "std::string
> const&" while the others are usually "const std::string &".
> 
> Eike

This is just a matter of style, both notations are fully equivalent.

Michael