[cmake-developers] [PATCH 0/7] Preparation for Ninja generator: refactorings, bug fixes

[Brad King]

On 9/26/2011 11:48 PM, Peter Collingbourne wrote:
> Now that the Ninja generator is passing all tests on Linux, I have
> decided to start preparing patches, and I am starting with some
> refactorings and bug fixes developed in the course of developing the
> Ninja generator.  Three of the patches were originally by Nicolas
> Despres, the rest are by myself.

Fantastic!  Thanks for the well-formatted patch submission.  It was easy
to review the inline patch series.  I also fetched your prep branch from
github.  I think we can merge it as soon as the 2.8.6 release is finalized.

Patches 1-6 look good.  Please expand the commit message in patch 7 to
elaborate on the specific problems it fixes.  That looks like a real bug
fix rather than just refactoring.  I guess no one has been using per-config
link flags.

Thanks!
-Brad