[cmake-developers] [PATCH] UsePkgConfig: improve documentation

[Eric Noulard]

2011/9/22 Alexander Neundorf <neundorf at kde.org>:
> On Thursday, September 22, 2011 03:00:33 PM Rolf Eike Beer wrote:
>> > On Thursday, September 22, 2011 01:52:51 PM Rolf Eike Beer wrote:
>> >> From 3f500a5c655cc4c12ecf6f774602b2a10cae0365 Mon Sep 17 00:00:00 2001
>> >> From: Rolf Eike Beer <eike at sf-mail.de>
>> >> Date: Thu, 22 Sep 2011 13:48:15 +0200
>> >>
>> >> Tell the people in the documentation which module to use instead.
>> >
>> > Thanks, merged into next (the MinorPkgConfigDocImprovement branch)
>>
>> Well, wrong. You took the patch and committed the changes, so once again
>
> Nitpicking: what I committed were actually not exactly your changes, but fixes
> inspired by your patch ;-)

When I do minor or no change from a contributor's patch I commit
I usually do the following:

0) go into appropriate branch
1) git apply user.patch
... review - test - modify loop
2) git commit --author="Rolf Eike Beer <eike at sf-mail.de>"  -s
... push as usual.

the --author will setup appropriate authorship and -s add the
Signed-Off message.
This gives something like:
http://cmake.org/gitweb?p=cmake.git;a=commit;h=b22fcfb0c55ec145a4cf7405120c708fa136d928

other commiter do add (?manually?) an "Inspired-by:" line):
http://cmake.org/gitweb?p=cmake.git;a=commit;h=8dfe74c358c5c5b364341a5fda1a43281d5bcc97

my 2 cents to respect authorship.

-- 
Erk
Membre de l'April - « promouvoir et défendre le logiciel libre » -
http://www.april.org