[cmake-developers] [PATCH] LoadCommand test: cleanup

Rolf Eike Beer eike at sf-mail.de
Mon Oct 17 09:18:11 EDT 2011


> On 10/6/2011 8:24 AM, Rolf Eike Beer wrote:
>
>>
>>
>> Bill, that Watcom stuff was introduced by you in
>> 9891260a6dab66c9ea44b5c2e244f3128625baf5.
>> I simply assumed it was a debug leftover as setting a variable to the
>> value
>> it already has looks pretty pointless to me.
>>
>>
>>
>> diff --git a/Tests/LoadCommand/CMakeCommands/CMakeLists.txt
>> b/Tests/LoadCommand/CMakeCommands/CMakeLists.txt
>> index 953d05c..5cdbc59 100644
>> --- a/Tests/LoadCommand/CMakeCommands/CMakeLists.txt
>> +++ b/Tests/LoadCommand/CMakeCommands/CMakeLists.txt
>> @@ -5,9 +5,6 @@ IF (MUDSLIDE_TYPE MATCHES MUCHO)
>>     ADD_DEFINITIONS(-DMUCHO_MUDSLIDE)
>>   ENDIF (MUDSLIDE_TYPE MATCHES MUCHO)
>>
>> -IF(WATCOM)
>> -  SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
>> -ENDIF(WATCOM)
>
> Hmmm...  It could be some sort of odd escape thing going on that an
> extra pass by the CMake parser fixes...  I guess we can push it into the
> dashboard and see if it fails.  I can not remember at this point, but
> watcom is a picky odd compiler.

Is anyone going to pick this patch up?

Eike



More information about the cmake-developers mailing list