[cmake-developers] Some documentation patches
Brad King
brad.king at kitware.com
Wed Oct 12 18:24:00 EDT 2011
On 10/12/2011 11:10 AM, Nicolas Desprès wrote:
> I have extracted some documentation patches I have made while I was
> working on the ninja-generator and some enhancement for ccmake. I
> would like to submit them now. They are addressing:
> - usage messages
> - doxygen documentation
> - online help in ccmake
Fantastic. This is a lot of tedious cleanup work. Thanks for doing it!
Here are a few comments from review:
- The "Factor toggle key help instructions" commit adds lines longer than
79 characters. Please reformat them to use shorter lines.
- Some of the patches remove trailing whitespace from lines unrelated to
the real change. Please identify the set of files from which you've
blanket-removed whitespace, create a commit that does just that, and
then rebase the rest of the patches on it. That will make the changes
easier to see/review/blame.
- Please prefix each commit message with the section affected, when
applicable. For example, "ccmake: " or "doxygen: ".
Thanks,
-Brad
More information about the cmake-developers
mailing list