[cmake-developers] [CMake 0012508]: Cosmetic fix for cmake configure (Tests/FindPackageModeMakefileTest/CMakeLists.txt)
Mantis Bug Tracker
mantis at public.kitware.com
Mon Oct 10 07:00:47 EDT 2011
The following issue has been SUBMITTED.
======================================================================
http://www.cmake.org/Bug/view.php?id=12508
======================================================================
Reported By: David Coppa
Assigned To:
======================================================================
Project: CMake
Issue ID: 12508
Category: CMake
Reproducibility: always
Severity: tweak
Priority: normal
Status: new
======================================================================
Date Submitted: 2011-10-10 07:00 EDT
Last Modified: 2011-10-10 07:00 EDT
======================================================================
Summary: Cosmetic fix for cmake configure
(Tests/FindPackageModeMakefileTest/CMakeLists.txt)
Description:
On OpenBSD, during bootstrap for cmake 2.8.6, you have the following output:
<...>
-- Looking for a Fortran compiler
-- Looking for a Fortran compiler - /usr/local/bin/g77
make: unknown option -- v
usage: make [-BeiknPqrSst] [-D variable] [-d flags] [-f makefile]
[-I directory] [-j max_jobs] [-m directory] [-V variable]
[NAME=value] [target ...]
-- Looking for Q_WS_X11
-- Looking for Q_WS_X11 - found
<...>
That's ugly to see. The attached diff fixes this "issue".
I think it's acceptable, since GNU make sends its "-v" output to stdout.
diff --git a/Tests/FindPackageModeMakefileTest/CMakeLists.txt
b/Tests/FindPackageModeMakefileTest/CMakeLists.txt
index def8d63..3674f0e 100644
--- a/Tests/FindPackageModeMakefileTest/CMakeLists.txt
+++ b/Tests/FindPackageModeMakefileTest/CMakeLists.txt
@@ -7,6 +7,7 @@ if(UNIX AND "${CMAKE_GENERATOR}" MATCHES "Makefile")
# is AFAIK a GNU make extension. Alex
execute_process(COMMAND ${CMAKE_MAKE_PROGRAM} -v
OUTPUT_VARIABLE makeVersionOutput
+ ERROR_QUIET
TIMEOUT 10)
string(TOUPPER "${makeVersionOutput}" MAKE_VERSION_OUTPUT)
if("${MAKE_VERSION_OUTPUT}" MATCHES ".*GNU MAKE.*")
======================================================================
Issue History
Date Modified Username Field Change
======================================================================
2011-10-10 07:00 David Coppa New Issue
2011-10-10 07:00 David Coppa File Added: FindPackageModeMakefileTest.diff
======================================================================
More information about the cmake-developers
mailing list