[cmake-developers] Setting the link interface and dependencies in one command

Stephen Kelly steveire at gmail.com
Sat Oct 8 09:34:19 EDT 2011


Bill Hoffman wrote:

> On 10/7/2011 11:30 AM, Brad King wrote:
>> On 10/7/2011 11:23 AM, Stephen Kelly wrote:
>>> Brad King wrote:
>>>> Good start. Please change the three Doing*Interface modes into an
>>>> enumeration so we don't have to worry about keeping three booleans
>>>> in a consistent state.
>>>
>>> Done.
>>>
>>>> Also, I think the documentation can be simplified for that signature:
>>>
>>> Done.
>>
>> Thanks.
>>
>> Unfortunately I won't have time to do a serious review of the topics
>>
>> cmake-link-interface-libraries
>> target-link-libraries-interfaces
>>
>> for a couple of weeks. You're welcome to keep merging to next to see
>> results on the dashboard. It won't be in master until after I can take
>> time for a thorough review.
>>
>> Thanks for working on this!
>>
> Please keep working on fixing the dashboard, there are a few style
> errors here:
> http://www.cdash.org/CDash/viewBuildError.php?buildid=1601031

This seems to be introduced by the ninja branch.

I still can't get the style checker working as expected anyway though.





More information about the cmake-developers mailing list