[cmake-developers] [PATCH 7/7] Fix configuration-dependent flag lookup in cmLocalGenerator::GetTargetFlags

[Peter Collingbourne]

On Tue, Sep 27, 2011 at 05:33:44PM +0200, Nicolas Desprès wrote:
> On Tue, Sep 27, 2011 at 4:03 PM, Rolf Eike Beer <eike at sf-mail.de> wrote:
> >> ---
> >>  Source/cmLocalGenerator.cxx |   23 ++++++++++++++++++++---
> >>  1 files changed, 20 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/Source/cmLocalGenerator.cxx b/Source/cmLocalGenerator.cxx
> >> index aeda164..4044876 100644
> >> --- a/Source/cmLocalGenerator.cxx
> >> +++ b/Source/cmLocalGenerator.cxx
> >> @@ -1463,6 +1463,17 @@ void cmLocalGenerator::GetTargetFlags(std::string&
> >> linkLibs,
> >>          linkFlags += targetLinkFlags;
> >>          linkFlags += " ";
> >>          }
> >> +      if(buildType.size())
> >
> > This could also be "if(!buildType.empty())", but it's hard to decide which
> > one to use. This file alone uses a great mixture of both variants.
> 
> Your version is more readable.

I agree, and I decided to modify this patch to use
"if(!buildType.empty())" consistently within this function.

Thanks,
-- 
Peter