[cmake-developers] Topic hdf5-module-bug-fix

[Will Dicharry]

Brad King wrote:
> On 05/25/2011 02:59 PM, Will Dicharry wrote:
>   
>> I fixed your issues and added a couple more fixes for problems with the 
>> module. They have been merged with stage/next.
>>     
>
> Thanks.  Those look pretty good.  However, this looks strange:
>
> +if( HDF5_FOUND )
> +    mark_as_advanced(
> +        HDF5_INCLUDE_DIRS
>
>   

It appears that all of them were unnecessary anyway since I was setting 
them as advanced further up the module. Also, the set of 
HDF5_INCLUDE_DIR for backwards compatibility should have been in the 
autoconf build control path. These have been fixed, pushed, and merged.

> The mark_as_advanced command should only be given the names of cached
> values.  All the plural names can be dropped.  The names of values
> used for find_*() commands in the autoconf-built section should be
> added.  Also, the advanced status should not depend on whether HDF5
> is found.  Perhaps those marks can move into the section that creates
> the cache entries.
>
> Thanks,
> -Brad
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5852 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20110525/fa211ec3/attachment-0002.bin>