[cmake-developers] memory leaks in cpack

Bill Hoffman bill.hoffman at kitware.com
Sun Mar 20 10:13:22 EDT 2011


On 3/19/2011 6:18 AM, Eric Noulard wrote:

> I did just pushed the fix to stage.
> I did change the cmCPackGenerator::ReadListFile return status in order
> to return "false" if the list file read ends-up with an ERROR or FATAL_ERROR.
> I think this is more what you would expect from this method.
> Currently it was used by CPack RPM, Deb and NSIS generators, RPM and Deb
> did check the return value whereas NSIS just ignore it :-].
> So the change should be safe.
>
> Merge topic 'CPackDeb-fixTestCrash' into next
>
> 21007f8 CPack fix CPackDeb crash when CPackDeb.cmake ends with a FATAL_ERROR
>
> Pushing upstream next
> To git at cmake.org:cmake.git
>
>

Simple install seems to be failing after your changes:

http://www.cdash.org/CDash/testDetails.php?test=88344080&build=911504


-Bill



More information about the cmake-developers mailing list