[cmake-developers] XCodeGenerator bug; ReRunCMake.make only includes toplevel dependencies

Brad King brad.king at kitware.com
Wed Jan 12 13:08:36 EST 2011


On 1/12/2011 12:54 PM, Johan Björk wrote:
> The XCode generator does not properly add recursive dependencies,
> resulting in that the project files won't be re-generated correctly.
> The problem should be easily reproduced in any project that has at least
> one add_subdirectory() command, just study the
> <build>/CMakeScripts/ReRunCMake.make file.

:(

> Attached patch seems to fix the issue

:)

> Is this an acceptable workflow for small fixes like this, or is
> the preferred way pull requests at github?

Yes.  We like to keep discussion on the mailing list.

> What branch should I use, next or master?

Please start all new topics from master.  The 'next' branch is
for integration testing only.

> The patch is based of the current master.

Great.  We'll review it.

Thanks,
-Brad



More information about the cmake-developers mailing list