[cmake-developers] Fixing #12262 for 2.8.7 : dependency scanning and CMakeDirectoryInformation.cmake
Alexander Neundorf
neundorf at kde.org
Sun Dec 18 13:17:14 EST 2011
Hi,
this patch fixes dependency scanning for ASM files:
http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=215d0636544f801c20e9154c642f570df2cfca34
It changes the way the CMAKE_CXX_INCLUDE_PATH and CMAKE_Fortran_INCLUDE_PATH
variables are written into CMakeDirectoryInformation.cmake.
Instead of writing the hardcoded, it now loops over all enabled languages and
writes the entry for each of them.
To me this felt better than hardcoding CMAKE_ASM_INCLUDE_PATH.
OTOH, this has the effect that e.g. CMAKE_Fortran_INCLUDE_PATH only exists if
Fortran has been enabled, the same for CXX. Also, this could now also end up
for other languages in the same file, e.g. a CMAKE_D_INCLUDE_PATH will now
appear for the people using the D support for cmake.
An alternative fix is in AddIncludePathForASMToDirectoryInformationFile, which
simply adds CMAKE_ASM_INCLUDE_PATH, and doesn't change anything else.
This is less intrusive.
Which one should I merge into next ?
Alex
More information about the cmake-developers
mailing list