[cmake-developers] [PATCH] Also match "error" at start of line as build error, not only "Error"

[Michael Wild]

On 04/14/2011 11:09 AM, Rolf Eike Beer wrote:
>> On 04/14/2011 09:12 AM, Rolf Eike Beer wrote:
>>> Doesn't make any sense to me not to catch those, too.
>>>
>>> Eike
>>>
>>>
>>> 0001-make-some-Error-match-strings-also-match-error.patch
>>>
>>>
>>> From 4e6296a227b939e343949ec1452a59829f0ca6bd Mon Sep 17 00:00:00 2001
>>> From: Rolf Eike Beer <eike at sf-mail.de>
>>> Date: Thu, 14 Apr 2011 09:08:13 +0200
>>> Subject: [PATCH] make some "Error" match strings also match "error"
>>>
>>> This was not flagged as build error in CDash in one of our builds:
>>>
>>> error: reading config file failed
>>> ---
>>>  Source/CTest/cmCTestBuildHandler.cxx |    6 +++---
>>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Source/CTest/cmCTestBuildHandler.cxx
>>> b/Source/CTest/cmCTestBuildHandler.cxx
>>> index 86bd85d..87840d8 100644
>>> --- a/Source/CTest/cmCTestBuildHandler.cxx
>>> +++ b/Source/CTest/cmCTestBuildHandler.cxx
>>> @@ -46,10 +46,10 @@ static const char* cmCTestErrorMatches[] = {
>>>    ":.*[Pp]ermission [Dd]enied",
>>>    "([^ :]+):([0-9]+): ([^ \\t])",
>>>    "([^:]+): error[ \\t]*[0-9]+[ \\t]*:",
>>> -  "^Error ([0-9]+):",
>>> +  "^[Ee]rror ([0-9]+):",
>>>    "^Fatal",
>>> -  "^Error: ",
>>> -  "^Error ",
>>> +  "^[Ee]rror: ",
>>> +  "^[Ee]rror ",
>>>    "[0-9] ERROR: ",
>>>    "^\"[^\"]+\", line [0-9]+: [^Ww]",
>>>    "^cc[^C]*CC: ERROR File = ([^,]+), Line = ([0-9]+)",
>>
>> Would make even more sense to use
>>
>> "^[Ee][Rr][Rr][Oo][Rr]:? "
> 
> Probably, but I don't know if the regex implementation understands '?'. At
> least it is never used in those expressions.
> 
> Eike

Reading Source/kwsys/RegularExpression.hxx.in it seems so. You could
also split it in two expressions, the important part was that any
capitalization of ERROR would be matched.

Michael