[cmake-developers] [Cmake-commits] CMake branch, next, updated. v2.8.2-543-g7485a2c

[Philip Lowman]

Brad,

I think that's a good addition to Darwin.cmake, but in this (rare) case the
patch for FindGTK2 still needs to go in.  The reason why is that GTK2 is a
little weird in that it places config header files in
<prefix>/lib/some_directory (much to my chagrin).  Since find_path() would
only automatically search CMAKE_SYSTEM_PREFIX_PATH/include, and not lib, the
change to Darwin.cmake would not be enough to find all of the header file
paths.

The change to Darwin.cmake still seems like a good idea though.

On Tue, Aug 31, 2010 at 2:16 PM, Brad King <brad.king at kitware.com> wrote:

> On 08/26/2010 12:17 AM, Philip Lowman wrote:
> >     10688: FindGTK2.cmake doesn't auto-detect macports
> [snip]
> > @@ -184,6 +186,8 @@ function(_GTK2_FIND_INCLUDE_DIR _var _hdr)
> >              /usr/openwin/lib
> >              /sw/include
> >              /sw/lib
> > +            /opt/local/include
> > +            /opt/local/lib
> >              $ENV{GTKMM_BASEPATH}/include
> >              $ENV{GTKMM_BASEPATH}/lib
> >              [HKEY_CURRENT_USER\\SOFTWARE\\gtkmm\\2.4;Path]/include
>
> Rather than fixing this for one specific package, perhaps the patch
> below is better?  Does it fix this module too?
>
> Thanks,
> -Brad
>
>
> diff --git a/Modules/Platform/Darwin.cmake b/Modules/Platform/Darwin.cmake
> index c8bcad1..db0642e 100644
> --- a/Modules/Platform/Darwin.cmake
> +++ b/Modules/Platform/Darwin.cmake
> @@ -235,4 +235,7 @@ SET(CMAKE_SYSTEM_APPBUNDLE_PATH
>   /Developer/Applications)
>
>  INCLUDE(Platform/UnixPaths)
> -LIST(APPEND CMAKE_SYSTEM_PREFIX_PATH /sw)
> +LIST(APPEND CMAKE_SYSTEM_PREFIX_PATH
> +  /sw        # Fink
> +  /opt/local # MacPorts
> +  )
>



-- 
Philip Lowman
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20100831/e85aaa7e/attachment.html>