[cmake-developers] fphsa capitalization

Alexander Neundorf neundorf at kde.org
Sat Aug 14 12:59:42 EDT 2010


On Saturday 14 August 2010, you wrote:
...
> find_package command, it makes a lot of sense to use that same
> exact-case name as a prefix for the variables set by that find module.
> My hope is that with the conversion pain removed,

I'm afraid this wouldn't remove my personal (KDE's) conversion pain, see 
below.

> Alex would be
> willing to go along with the exact case naming convention so that

It's not that I don't like ExactCase, I just don't think changing from the 
current de-facto standard (90% UPPERCASE) without real need to a different 
one is a good idea.

Or in other words: I don't feel like going through the 67 find-modules in 
kdelibs and fixing them to provide also Exact case, and while doing this 
answering emails from KDE developers wondering what I'm doing and why ("CMake 
developers decided that the new standard is ExactCase").
Also, in KDE there are not only the find-modules in kdelibs (the 89 files I 
mentioned, there are find modules in the other KDE modules too (kdenetwork, 
kdebase, kdegraphics, koffice, extragear, ...)
They are not that many, but I assume that most of the modules there are also 
using UPPERCASE. 
OTOH fixing the 6 ExactCase files to provide also UPPERCASE sounds reasonably 
to me.

I just checked cmake 2.4.1 (from early 2006, when we started to use cmake in 
KDE):
Checked <63> files, exact=0, allUp=21, both=21 unclear=21

And cmake 2.4.3:
Checked <64> files, exact=2, allUp=21, both=21 unclear=20
(FindBoost and FindSubversion)

To me this shows that in 2.4.x UPPERCASE indeed was the standard, and this is 
what FPHSA() does.

Both naming rules are very simple (ExactCase and ALLUPPERCASE).
What is the benefit we gain from using ExactCase compared to UPPERCASE ?

Alex



More information about the cmake-developers mailing list