[cmake-developers] CPack API redesign

[Eric Noulard]

2010/8/11 Brad King <brad.king at kitware.com>:
> On 08/10/2010 04:01 PM, Eric Noulard wrote:
>> The pullable changes includes the API update for **ALL** current CPack
>> generator
>
> This is a good change.  Thanks for the work!
>
>> the changes have been tested on a Linux x64 box:
>>
>>  1) with  ctest -R "CPack.*"
>>  2) by hand for several project (including CMake itself)
>>      for DEB   NSIS  RPM   STGZ  TBZ2  TGZ   TZ    ZIP
>>
>> Cygwin (Source and Binary)
>> the various Mac OS generator (PackageMaker, OSXX11, Bundle)
>> have been updated too but
>>
>> I did it **blindly** because I have to Mac nor Windows box at hand.
>
> I built your topic on Windows with VC9, MSys, and Cygwin.  The same
> tests (-R CPack and hand packaging of CMake) work for all of them.
>
> However, the Mac does not build.  After the patch below, I still get
>
> /.../CMake/Source/CPack/cmCPackDragNDropGenerator.cxx: In member function 'virtual int cmCPackDragNDropGenerator::PackageFiles()':
> /.../CMake/Source/CPack/cmCPackDragNDropGenerator.cxx:110: error: 'outFileName' was not declared in this scope
>
> Perhaps it needs to use packageFileNames[0]?

Yes, sure I did miss that one.
I did a thorough read but I should have used search & replace...

> -Brad
>
> diff --git a/Source/CPack/cmCPackDragNDropGenerator.h b/Source/CPack/cmCPackDragNDropGenerator.h
> index 43a9617..8a4d774 100644
> --- a/Source/CPack/cmCPackDragNDropGenerator.h
> +++ b/Source/CPack/cmCPackDragNDropGenerator.h
> @@ -29,8 +29,7 @@ public:
>  protected:
>   virtual int InitializeInternal();
>   virtual const char* GetOutputExtension();
> -  int CompressFiles(const char* outFileName, const char* toplevel,
> -    const std::vector<std::string>& files);
> +  int PackageFiles();
>
>   bool CopyFile(cmOStringStream& source, cmOStringStream& target);
>   bool RunCommand(cmOStringStream& command, std::string* output = 0);
>

With that patch does it work on the Mac?
If yes, I'll update this in a couple.

-- 
Erk
Membre de l'April - « promouvoir et défendre le logiciel libre » -
http://www.april.org