[cmake-developers] [ctest][cmCTestBuildHandler.cxx] odd code

[Maik Beckmann]

Hi,

This is from cmCTestBuildHander.cxx
{{{
      if ( !cm->SourceFile.empty() && cm->LineNumber >= 0 )
        {
        if ( cm->SourceFile.size() > 0 ) // is always true
          {
          os << "\t\t<SourceFile>" << cm->SourceFile << "</SourceFile>"
            << std::endl;
          }
        if ( cm->SourceFileTail.size() > 0 ) // SourceFileTail isn't set 
anywhere
          {
          os << "\t\t<SourceFileTail>" << cm->SourceFileTail
            << "</SourceFileTail>" << std::endl;
          }
        if ( cm->LineNumber >= 0 ) // is always true
          {
          os << "\t\t<SourceLineNumber>" << cm->LineNumber
            << "</SourceLineNumber>" << std::endl;
          }
}}}
which IMHO can be replaced with
{{{
      if ( !cm->SourceFile.empty() && cm->LineNumber >= 0 )
        {
        os << "\t\t<SourceFile>" << cm->SourceFile << "</SourceFile>"
           << std::endl;
        os << "\t\t<SourceLineNumber>" << cm->LineNumber
           << "</SourceLineNumber>" << std::endl;
        }
}}}

Patch is attached.


Best,
 -- Maik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmCTestBuildHandler.patch
Type: text/x-diff
Size: 1634 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20080531/881d8f38/attachment-0002.patch>