[cmake-developers] Fwd: Bug#419134: FindMPEG2.cmake uses fragile path for FindSDL.cmake

[Andy Cedilnik]

---------- Forwarded message ----------
From: Michael Hanke <michael.hanke at gmail.com>
Date: Apr 13, 2007 4:47 PM
Subject: Bug#419134: FindMPEG2.cmake uses fragile path for FindSDL.cmake
To: Debian Bug Tracking System <submit at bugs.debian.org>

Package: cmake
Version: 2.4.5-1
Severity: normal
Tags: patch


Hi,

while working on the packaging of VXL I found that the cmake module
FindMPEG2.cmake uses a fragile path for including FindSDL.cmake.

I propose to apply the following patch:

--- FindMPEG2.cmake.old 2006-12-04 22:58:24.000000000 +0100
+++ FindMPEG2.cmake     2007-04-13 22:30:23.000000000 +0200
@@ -35,7 +35,7 @@

     #some native mpeg2 installations will depend
     #on libSDL, if found, add it in.
-    INCLUDE( ${MODULE_PATH}/FindSDL.cmake )
+    INCLUDE( ${CMAKE_ROOT}/Modules/FindSDL.cmake )
     IF(SDL_FOUND)
       SET( MPEG2_LIBRARIES ${MPEG2_LIBRARIES} ${SDL_LIBRARY})
     ENDIF(SDL_FOUND)

VXL 1.8.0 redefines the MODULE_PATH variable and therefore fails to build on
Debian systems. As this name is rather general it could possibly happen
with other software as well.

Applying the above patch seems to be reasonable to me as most other
cmake modules choose this way as well:

michael at gandalf:~$ grep -R {CMAKE_ROOT}/Modules /usr/share/cmake-2.4/Modules/*
|wc -l
50


Thanks,

Michael


-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (600, 'testing'), (200, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.18-4-k7 (SMP w/1 CPU core)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages cmake depends on:
ii  libc6                       2.3.6.ds1-13 GNU C Library: Shared libraries
ii  libgcc1                     1:4.1.1-21   GCC support library
ii  libncurses5                 5.5-5        Shared libraries for terminal
hand
ii  libstdc++6                  4.1.1-21     The GNU Standard C++ Library v3

cmake recommends no packages.

-- no debconf information

--
GPG key:  1024D/3144BE0F Michael Hanke
http://apsy.gse.uni-magdeburg.de/hanke
ICQ: 48230050




-- 
-------------------------------------------
Andy Cedilnik
Kitware Inc.
http://www.kitware.com
Phone: +1 518 371 3971 x110
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20070413/2917dd9f/attachment-0001.html>