[Cmake-commits] CMake branch, master, updated. v3.9.0-rc3-117-g67fe574

Kitware Robot kwrobot at kitware.com
Fri Jun 16 09:55:06 EDT 2017


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, master has been updated
       via  67fe57478b88fac76595d71e74934970ca6960f4 (commit)
       via  4dbbb275d5c25745d8f2b45d092245e61dd1f72f (commit)
       via  b0725f2fcd8c4a89e7e34a0b4eff4c6bc942e304 (commit)
       via  b7799f07d1bcf2708976b41aa07047c04e5ee3d0 (commit)
      from  c670d1b50bc08e307f021f46c96520701b075b57 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=67fe57478b88fac76595d71e74934970ca6960f4
commit 67fe57478b88fac76595d71e74934970ca6960f4
Merge: 4dbbb27 b7799f0
Author:     Brad King <brad.king at kitware.com>
AuthorDate: Fri Jun 16 09:51:55 2017 -0400
Commit:     Brad King <brad.king at kitware.com>
CommitDate: Fri Jun 16 09:51:55 2017 -0400

    Merge branch 'release-3.9'


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4dbbb275d5c25745d8f2b45d092245e61dd1f72f
commit 4dbbb275d5c25745d8f2b45d092245e61dd1f72f
Merge: c670d1b b0725f2
Author:     Brad King <brad.king at kitware.com>
AuthorDate: Fri Jun 16 13:50:45 2017 +0000
Commit:     Kitware Robot <kwrobot at kitware.com>
CommitDate: Fri Jun 16 09:51:02 2017 -0400

    Merge topic 'doc-dev-maint'
    
    b0725f2f Help/dev: Add review instructions to maintainer guide
    
    Acked-by: Kitware Robot <kwrobot at kitware.com>
    Merge-request: !973


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b0725f2fcd8c4a89e7e34a0b4eff4c6bc942e304
commit b0725f2fcd8c4a89e7e34a0b4eff4c6bc942e304
Author:     Brad King <brad.king at kitware.com>
AuthorDate: Thu Jun 15 14:30:28 2017 -0400
Commit:     Brad King <brad.king at kitware.com>
CommitDate: Thu Jun 15 14:32:54 2017 -0400

    Help/dev: Add review instructions to maintainer guide

diff --git a/Help/dev/maint.rst b/Help/dev/maint.rst
index 78c06df..c448445 100644
--- a/Help/dev/maint.rst
+++ b/Help/dev/maint.rst
@@ -8,6 +8,36 @@ See documentation on `CMake Development`_ for more information.
 
 .. contents:: Maintainer Processes:
 
+Review a Merge Request
+======================
+
+The `CMake Review Process`_ requires a maintainer to issue the ``Do: merge``
+command to integrate a merge request.  Please check at least the following:
+
+* If the MR source branch is not named well for the change it makes
+  (e.g. it is just ``master`` or the patch changed during review),
+  add a ``Topic-rename: <topic>`` trailing line to the MR description
+  to provide a better topic name.
+
+* If the MR introduces a new feature or a user-facing behavior change,
+  such as a policy, ensure that a ``Help/release/dev/$topic.rst`` file
+  is added with a release note.
+
+* If a commit changes a specific area, such as a module, its commit
+  message should have an ``area:`` prefix on its first line.
+
+* If a commit fixes a tracked issue, its commit message should have
+  a trailing line such as ``Fixes: #00000``.
+
+* Ensure that the MR has been tested sufficiently.  Typically it should
+  be staged for nightly testing with ``Do: stage``.  Then manually
+  review the `CMake CDash Page`_ to verify that no regressions were
+  introduced.  (Learn to tolerate spurious failures due to idiosyncrasies
+  of various nightly builders.)
+
+.. _`CMake Review Process`: review.rst
+.. _`CMake CDash Page`: https://open.cdash.org/index.php?project=CMake
+
 Branch a New Release
 ====================
 

-----------------------------------------------------------------------

Summary of changes:
 Help/dev/maint.rst |   30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)


hooks/post-receive
-- 
CMake


More information about the Cmake-commits mailing list