[Cmake-commits] CMake branch, next, updated. v3.7.0-rc1-104-ge5abe18

Brad King brad.king at kitware.com
Thu Oct 6 10:14:58 EDT 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
       via  e5abe1865909ed63e14069fa418b01f20a6ca01e (commit)
       via  f53b01ff0fdead346f3f63310d4a7359db269fb4 (commit)
       via  ca50c89e416934a586ad6839b2aaba8e7257cc2e (commit)
      from  ace79e42fd521f9b6f35ae6e985441ef14b6d03b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e5abe1865909ed63e14069fa418b01f20a6ca01e
commit e5abe1865909ed63e14069fa418b01f20a6ca01e
Merge: ace79e4 f53b01f
Author:     Brad King <brad.king at kitware.com>
AuthorDate: Thu Oct 6 10:14:56 2016 -0400
Commit:     CMake Topic Stage <kwrobot at kitware.com>
CommitDate: Thu Oct 6 10:14:56 2016 -0400

    Merge topic 'cpack-rpm-debuginfo-fixes' into next
    
    f53b01ff CPack/RPM debuginfo package without binaries
    ca50c89e CPack/RPM debuginfo package objdump error suppression


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f53b01ff0fdead346f3f63310d4a7359db269fb4
commit f53b01ff0fdead346f3f63310d4a7359db269fb4
Author:     Domen Vrankar <domen.vrankar at gmail.com>
AuthorDate: Thu Oct 6 08:04:58 2016 +0200
Commit:     Brad King <brad.king at kitware.com>
CommitDate: Thu Oct 6 10:14:16 2016 -0400

    CPack/RPM debuginfo package without binaries
    
    Handle case when a component doesn't contain
    any debuginfo symbols.

diff --git a/Modules/CPackRPM.cmake b/Modules/CPackRPM.cmake
index 8f3f7ca..15b62c7 100644
--- a/Modules/CPackRPM.cmake
+++ b/Modules/CPackRPM.cmake
@@ -1477,16 +1477,22 @@ function(cpack_rpm_debugsymbol_check INSTALL_FILES WORKING_DIR)
     endif()
   endforeach()
 
-  list(REMOVE_DUPLICATES mkdir_list_)
-  unset(TMP_RPM_DEBUGINFO_INSTALL)
-  foreach(part_ IN LISTS mkdir_list_)
-    string(APPEND TMP_RPM_DEBUGINFO_INSTALL "mkdir -p \"${part_}\"\n")
-  endforeach()
+  list(LENGTH mkdir_list_ len_)
+  if(len_)
+    list(REMOVE_DUPLICATES mkdir_list_)
+    unset(TMP_RPM_DEBUGINFO_INSTALL)
+    foreach(part_ IN LISTS mkdir_list_)
+      string(APPEND TMP_RPM_DEBUGINFO_INSTALL "mkdir -p \"${part_}\"\n")
+    endforeach()
+  endif()
 
-  list(REMOVE_DUPLICATES cp_list_)
-  foreach(part_ IN LISTS cp_list_)
-    string(APPEND TMP_RPM_DEBUGINFO_INSTALL "${part_}\n")
-  endforeach()
+  list(LENGTH cp_list_ len_)
+  if(len_)
+    list(REMOVE_DUPLICATES cp_list_)
+    foreach(part_ IN LISTS cp_list_)
+      string(APPEND TMP_RPM_DEBUGINFO_INSTALL "${part_}\n")
+    endforeach()
+  endif()
 
   if(NOT DEFINED CPACK_RPM_DEBUGINFO_EXCLUDE_DIRS)
     set(CPACK_RPM_DEBUGINFO_EXCLUDE_DIRS /usr /usr/src /usr/src/debug)
@@ -1501,29 +1507,34 @@ function(cpack_rpm_debugsymbol_check INSTALL_FILES WORKING_DIR)
     message("CPackRPM:Debug: CPACK_RPM_DEBUGINFO_EXCLUDE_DIRS= ${CPACK_RPM_DEBUGINFO_EXCLUDE_DIRS}")
   endif()
 
-  list(REMOVE_DUPLICATES additional_sources_)
-  unset(additional_sources_all_)
-  foreach(source_ IN LISTS additional_sources_)
-    string(REPLACE "/" ";" split_source_ " ${source_}")
-    list(REMOVE_AT split_source_ 0)
-    unset(tmp_path_)
-    # Now generate all segments of the path
-    foreach(segment_ IN LISTS split_source_)
-      string(APPEND tmp_path_ "/${segment_}")
-      list(APPEND additional_sources_all_ "${tmp_path_}")
+  list(LENGTH additional_sources_ len_)
+  if(len_)
+    list(REMOVE_DUPLICATES additional_sources_)
+    unset(additional_sources_all_)
+    foreach(source_ IN LISTS additional_sources_)
+      string(REPLACE "/" ";" split_source_ " ${source_}")
+      list(REMOVE_AT split_source_ 0)
+      unset(tmp_path_)
+      # Now generate all segments of the path
+      foreach(segment_ IN LISTS split_source_)
+        string(APPEND tmp_path_ "/${segment_}")
+        list(APPEND additional_sources_all_ "${tmp_path_}")
+      endforeach()
     endforeach()
-  endforeach()
 
-  list(REMOVE_DUPLICATES additional_sources_all_)
-  list(REMOVE_ITEM additional_sources_all_ ${CPACK_RPM_DEBUGINFO_EXCLUDE_DIRS})
+    list(REMOVE_DUPLICATES additional_sources_all_)
+    list(REMOVE_ITEM additional_sources_all_
+      ${CPACK_RPM_DEBUGINFO_EXCLUDE_DIRS})
 
-  unset(TMP_DEBUGINFO_ADDITIONAL_SOURCES)
-  foreach(source_ IN LISTS additional_sources_all_)
-    string(APPEND TMP_DEBUGINFO_ADDITIONAL_SOURCES "${source_}\n")
-  endforeach()
+    unset(TMP_DEBUGINFO_ADDITIONAL_SOURCES)
+    foreach(source_ IN LISTS additional_sources_all_)
+      string(APPEND TMP_DEBUGINFO_ADDITIONAL_SOURCES "${source_}\n")
+    endforeach()
+  endif()
 
   set(TMP_RPM_DEBUGINFO_INSTALL "${TMP_RPM_DEBUGINFO_INSTALL}" PARENT_SCOPE)
-  set(TMP_DEBUGINFO_ADDITIONAL_SOURCES "${TMP_DEBUGINFO_ADDITIONAL_SOURCES}" PARENT_SCOPE)
+  set(TMP_DEBUGINFO_ADDITIONAL_SOURCES "${TMP_DEBUGINFO_ADDITIONAL_SOURCES}"
+    PARENT_SCOPE)
 endfunction()
 
 function(cpack_rpm_variable_fallback OUTPUT_VAR_NAME)

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ca50c89e416934a586ad6839b2aaba8e7257cc2e
commit ca50c89e416934a586ad6839b2aaba8e7257cc2e
Author:     Domen Vrankar <domen.vrankar at gmail.com>
AuthorDate: Wed Oct 5 22:31:41 2016 +0200
Commit:     Brad King <brad.king at kitware.com>
CommitDate: Thu Oct 6 10:14:11 2016 -0400

    CPack/RPM debuginfo package objdump error suppression
    
    objdump prints out error text if file is not an
    executable and that should be suppressed as we
    don't care about non executable files during that
    test

diff --git a/Modules/CPackRPM.cmake b/Modules/CPackRPM.cmake
index 3bbaae9..8f3f7ca 100644
--- a/Modules/CPackRPM.cmake
+++ b/Modules/CPackRPM.cmake
@@ -1427,7 +1427,8 @@ function(cpack_rpm_debugsymbol_check INSTALL_FILES WORKING_DIR)
     execute_process(COMMAND "${OBJDUMP_EXECUTABLE}" -h ${WORKING_DIR}/${F}
                     WORKING_DIRECTORY "${CPACK_TOPLEVEL_DIRECTORY}"
                     RESULT_VARIABLE OBJDUMP_EXEC_RESULT
-                    OUTPUT_VARIABLE OBJDUMP_OUT)
+                    OUTPUT_VARIABLE OBJDUMP_OUT
+                    ERROR_QUIET)
     # Check that if the given file was executable or not
     if(NOT OBJDUMP_EXEC_RESULT)
       string(FIND "${OBJDUMP_OUT}" "debug" FIND_RESULT)

-----------------------------------------------------------------------

Summary of changes:


hooks/post-receive
-- 
CMake


More information about the Cmake-commits mailing list