[Cmake-commits] CMake branch, next, updated. v2.8.8-3047-gb14b971

Brad King brad.king at kitware.com
Wed Jun 6 15:24:22 EDT 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
       via  b14b971803ca308860358d84e243455c5c763579 (commit)
       via  14cbd471feae912f91a5424ce0b4ab5153c7086c (commit)
       via  a6a3364a28a5b7123073c057b7243908532f2cc3 (commit)
       via  eb53bc27733e5762906eb251184df317f1c4664d (commit)
      from  a1de5ec6463cf250822309a241efbc02f559275e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b14b971803ca308860358d84e243455c5c763579
commit b14b971803ca308860358d84e243455c5c763579
Merge: a1de5ec 14cbd47
Author:     Brad King <brad.king at kitware.com>
AuthorDate: Wed Jun 6 15:24:19 2012 -0400
Commit:     CMake Topic Stage <kwrobot at kitware.com>
CommitDate: Wed Jun 6 15:24:19 2012 -0400

    Merge topic 'ninja-rspfile' into next
    
    14cbd47 Merge branch 'no-std-stringstream' into ninja-rspfile
    a6a3364 Avoid direct use of std::(o|)stringstream (#13272)
    eb53bc2 CMake Nightly Date Stamp


http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=14cbd471feae912f91a5424ce0b4ab5153c7086c
commit 14cbd471feae912f91a5424ce0b4ab5153c7086c
Merge: e3a1f72 a6a3364
Author:     Brad King <brad.king at kitware.com>
AuthorDate: Wed Jun 6 15:21:19 2012 -0400
Commit:     Brad King <brad.king at kitware.com>
CommitDate: Wed Jun 6 15:21:19 2012 -0400

    Merge branch 'no-std-stringstream' into ninja-rspfile
    
    Conflicts:
    	Source/cmGlobalNinjaGenerator.cxx
    	Source/cmLocalNinjaGenerator.cxx
    	Source/cmNinjaNormalTargetGenerator.cxx

diff --cc Source/cmGlobalNinjaGenerator.cxx
index c4b1cc9,40348e6..ae996ff
--- a/Source/cmGlobalNinjaGenerator.cxx
+++ b/Source/cmGlobalNinjaGenerator.cxx
@@@ -127,7 -123,7 +127,7 @@@ void cmGlobalNinjaGenerator::WriteBuild
  
    cmGlobalNinjaGenerator::WriteComment(os, comment);
  
-   std::stringstream arguments;
 -  cmOStringStream builds;
++  cmOStringStream arguments;
  
    // TODO: Better formatting for when there are multiple input/output files.
  
diff --cc Source/cmLocalNinjaGenerator.cxx
index a0141cf,f6a6bc2..d5baaee
--- a/Source/cmLocalNinjaGenerator.cxx
+++ b/Source/cmLocalNinjaGenerator.cxx
@@@ -275,16 -275,16 +275,16 @@@ std::string cmLocalNinjaGenerator::Buil
      return ":";
  #endif
  
-   std::ostringstream cmd;
 -  // TODO: This will work only on Unix platforms. I don't
 -  // want to use a link.txt file because I will lose the benefit of the
 -  // $in variables. A discussion about dealing with multiple commands in
 -  // a rule is started here:
 -  // groups.google.com/group/ninja-build/browse_thread/thread/d515f23a78986008
+   cmOStringStream cmd;
    for (std::vector<std::string>::const_iterator li = cmdLines.begin();
         li != cmdLines.end(); ++li) {
 -    if (li != cmdLines.begin())
 +    if (li != cmdLines.begin()) {
        cmd << " && ";
 +#ifdef _WIN32
 +    } else if (cmdLines.size() > 1) {
 +      cmd << "cmd.exe /c ";
 +#endif
 +    }
      cmd << *li;
    }
    return cmd.str();
diff --cc Source/cmNinjaNormalTargetGenerator.cxx
index ddf96eb,1751091..b38619a
--- a/Source/cmNinjaNormalTargetGenerator.cxx
+++ b/Source/cmNinjaNormalTargetGenerator.cxx
@@@ -239,11 -214,11 +239,11 @@@ cmNinjaNormalTargetGenerato
      std::string linkCmd =
        this->GetLocalGenerator()->BuildCommandLine(linkCmds);
  
 -    // Write the linker rule.
 +    // Write the linker rule with response file if needed.
-     std::ostringstream comment;
+     cmOStringStream comment;
      comment << "Rule for linking " << this->TargetLinkLanguage << " "
              << this->GetVisibleTypeName() << ".";
-     std::ostringstream description;
+     cmOStringStream description;
      description << "Linking " << this->TargetLinkLanguage << " "
                  << this->GetVisibleTypeName() << " $out";
      this->GetGlobalGenerator()->AddRule(ruleName,

http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a6a3364a28a5b7123073c057b7243908532f2cc3
commit a6a3364a28a5b7123073c057b7243908532f2cc3
Author:     Brad King <brad.king at kitware.com>
AuthorDate: Wed Jun 6 15:14:40 2012 -0400
Commit:     Brad King <brad.king at kitware.com>
CommitDate: Wed Jun 6 15:15:58 2012 -0400

    Avoid direct use of std::(o|)stringstream (#13272)
    
    Older C++ compilers do not provide a standard std::stringstream.
    Use our compatibility interfaces instead.

diff --git a/Source/cmGlobalNinjaGenerator.cxx b/Source/cmGlobalNinjaGenerator.cxx
index 0e89fab..40348e6 100644
--- a/Source/cmGlobalNinjaGenerator.cxx
+++ b/Source/cmGlobalNinjaGenerator.cxx
@@ -66,7 +66,7 @@ std::string cmGlobalNinjaGenerator::EncodeIdent(const std::string &ident,
   if (std::find_if(ident.begin(), ident.end(),
                    std::not1(std::ptr_fun(IsIdentChar))) != ident.end()) {
     static unsigned VarNum = 0;
-    std::ostringstream names;
+    cmOStringStream names;
     names << "ident" << VarNum++;
     vars << names.str() << " = " << ident << "\n";
     return "$" + names.str();
@@ -123,7 +123,7 @@ void cmGlobalNinjaGenerator::WriteBuild(std::ostream& os,
 
   cmGlobalNinjaGenerator::WriteComment(os, comment);
 
-  std::ostringstream builds;
+  cmOStringStream builds;
 
   // TODO: Better formatting for when there are multiple input/output files.
 
@@ -825,7 +825,7 @@ void cmGlobalNinjaGenerator::WriteTargetRebuildManifest(std::ostream& os)
   cmLocalGenerator *lg = this->LocalGenerators[0];
   cmMakefile* mfRoot = lg->GetMakefile();
 
-  std::ostringstream cmd;
+  cmOStringStream cmd;
   cmd << lg->ConvertToOutputFormat(
            mfRoot->GetRequiredDefinition("CMAKE_COMMAND"),
            cmLocalGenerator::SHELL)
diff --git a/Source/cmLocalNinjaGenerator.cxx b/Source/cmLocalNinjaGenerator.cxx
index 425b219..f6a6bc2 100644
--- a/Source/cmLocalNinjaGenerator.cxx
+++ b/Source/cmLocalNinjaGenerator.cxx
@@ -280,7 +280,7 @@ std::string cmLocalNinjaGenerator::BuildCommandLine(
   // $in variables. A discussion about dealing with multiple commands in
   // a rule is started here:
   // groups.google.com/group/ninja-build/browse_thread/thread/d515f23a78986008
-  std::ostringstream cmd;
+  cmOStringStream cmd;
   for (std::vector<std::string>::const_iterator li = cmdLines.begin();
        li != cmdLines.end(); ++li) {
     if (li != cmdLines.begin())
@@ -299,7 +299,7 @@ void cmLocalNinjaGenerator::AppendCustomCommandLines(const cmCustomCommand *cc,
     if (!wd)
       wd = this->GetMakefile()->GetStartOutputDirectory();
 
-    std::ostringstream cdCmd;
+    cmOStringStream cdCmd;
     cdCmd << "cd " << this->ConvertToOutputFormat(wd, SHELL);
     cmdLines.push_back(cdCmd.str());
   }
diff --git a/Source/cmNinjaNormalTargetGenerator.cxx b/Source/cmNinjaNormalTargetGenerator.cxx
index 8b86a98..1751091 100644
--- a/Source/cmNinjaNormalTargetGenerator.cxx
+++ b/Source/cmNinjaNormalTargetGenerator.cxx
@@ -215,10 +215,10 @@ cmNinjaNormalTargetGenerator
       this->GetLocalGenerator()->BuildCommandLine(linkCmds);
 
     // Write the linker rule.
-    std::ostringstream comment;
+    cmOStringStream comment;
     comment << "Rule for linking " << this->TargetLinkLanguage << " "
             << this->GetVisibleTypeName() << ".";
-    std::ostringstream description;
+    cmOStringStream description;
     description << "Linking " << this->TargetLinkLanguage << " "
                 << this->GetVisibleTypeName() << " $out";
     this->GetGlobalGenerator()->AddRule(ruleName,
@@ -353,7 +353,7 @@ void cmNinjaNormalTargetGenerator::WriteLinkStatement()
                                    /*implib=*/true).c_str());
 
   // Compute the comment.
-  std::ostringstream comment;
+  cmOStringStream comment;
   comment << "Link the " << this->GetVisibleTypeName() << " "
           << targetOutputReal;
 
diff --git a/Source/cmNinjaTargetGenerator.cxx b/Source/cmNinjaTargetGenerator.cxx
index e419a4d..32b8f93 100644
--- a/Source/cmNinjaTargetGenerator.cxx
+++ b/Source/cmNinjaTargetGenerator.cxx
@@ -365,9 +365,9 @@ cmNinjaTargetGenerator
     this->GetLocalGenerator()->BuildCommandLine(compileCmds);
 
   // Write the rule for compiling file of the given language.
-  std::ostringstream comment;
+  cmOStringStream comment;
   comment << "Rule for compiling " << language << " files.";
-  std::ostringstream description;
+  cmOStringStream description;
   description << "Building " << language << " object $out";
   this->GetGlobalGenerator()->AddRule(this->LanguageCompilerRule(language),
                                       cmdLine,
diff --git a/Source/cmQtAutomoc.cxx b/Source/cmQtAutomoc.cxx
index ca27530..3b8f9d8 100644
--- a/Source/cmQtAutomoc.cxx
+++ b/Source/cmQtAutomoc.cxx
@@ -18,6 +18,7 @@
 #include "cmSystemTools.h"
 
 #include <cmsys/Terminal.h>
+#include <cmsys/ios/sstream>
 
 #include <string.h>
 #if defined(__APPLE__)
@@ -549,7 +550,7 @@ bool cmQtAutomoc::RunAutomoc()
     this->GenerateMoc(it->first, it->second);
     }
 
-  std::stringstream outStream(std::stringstream::out);
+  cmsys_ios::stringstream outStream(std::ios::out);
   outStream << "/* This file is autogenerated, do not edit*/\n";
 
   bool automocCppChanged = false;
@@ -1077,7 +1078,7 @@ bool cmQtAutomoc::EndsWith(const std::string& str, const std::string& with)
 std::string cmQtAutomoc::ReadAll(const std::string& filename)
 {
   std::ifstream file(filename.c_str());
-  std::stringstream stream;
+  cmsys_ios::stringstream stream;
   stream << file.rdbuf();
   file.close();
   return stream.str();

-----------------------------------------------------------------------

Summary of changes:
 Source/CMakeVersion.cmake               |    2 +-
 Source/cmGlobalNinjaGenerator.cxx       |    6 +++---
 Source/cmLocalNinjaGenerator.cxx        |    4 ++--
 Source/cmNinjaNormalTargetGenerator.cxx |    6 +++---
 Source/cmNinjaTargetGenerator.cxx       |    4 ++--
 Source/cmQtAutomoc.cxx                  |    5 +++--
 6 files changed, 14 insertions(+), 13 deletions(-)


hooks/post-receive
-- 
CMake


More information about the Cmake-commits mailing list