[Cmake-commits] CMake branch, next, updated. v2.8.3-1272-gcf6b816

Brad King brad.king at kitware.com
Mon Jan 10 11:03:35 EST 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
       via  cf6b8169df6e2bfa2cb15e44bc35901744f49528 (commit)
       via  7ffe6d77da01674b1a67e518a83dab3b744d09b4 (commit)
      from  c436663e4c64fc29aaf3837fd486f4f83f971036 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cf6b8169df6e2bfa2cb15e44bc35901744f49528
commit cf6b8169df6e2bfa2cb15e44bc35901744f49528
Merge: c436663 7ffe6d7
Author:     Brad King <brad.king at kitware.com>
AuthorDate: Mon Jan 10 11:03:28 2011 -0500
Commit:     CMake Topic Stage <kwrobot at kitware.com>
CommitDate: Mon Jan 10 11:03:28 2011 -0500

    Merge topic 'doc-LOCATION-property-undefined-behavior' into next
    
    7ffe6d7 Document reading LOCATION early as undefined (#11671)


http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7ffe6d77da01674b1a67e518a83dab3b744d09b4
commit 7ffe6d77da01674b1a67e518a83dab3b744d09b4
Author:     Brad King <brad.king at kitware.com>
AuthorDate: Mon Jan 10 10:46:15 2011 -0500
Commit:     Brad King <brad.king at kitware.com>
CommitDate: Mon Jan 10 10:46:15 2011 -0500

    Document reading LOCATION early as undefined (#11671)
    
    Reading the LOCATION target property currently locks down the result and
    ignores any later changes to properties that affect it.  This may or may
    not be expected and may or may not be the behavior in earlier versions
    of CMake.  The property is documented as provided only for compatibility
    with CMake 2.4 and alternative interfaces are now available for all
    originally envisioned use cases.  We want to discourage its use without
    outright deprecating it.  Add documentation to explicitly state that
    reading the property before other properties are set is undefined.

diff --git a/Source/cmTarget.cxx b/Source/cmTarget.cxx
index 9a698c0..7617cca 100644
--- a/Source/cmTarget.cxx
+++ b/Source/cmTarget.cxx
@@ -517,7 +517,17 @@ void cmTarget::DefineProperties(cmake *cm)
      "In CMake 2.6 and above add_custom_command automatically recognizes a "
      "target name in its COMMAND and DEPENDS options and computes the "
      "target location.  "
-     "Therefore this property is not needed for creating custom commands.");
+     "In CMake 2.8.4 and above add_custom_command recognizes generator "
+     "expressions to refer to target locations anywhere in the command.  "
+     "Therefore this property is not needed for creating custom commands."
+     "\n"
+     "Do not read this property until after all other properties that can "
+     "affect the location of the target have been set.  "
+     "These include properties whose names match "
+     "\"(IMPLIB_)?(PREFIX|SUFFIX)\" or "
+     "\"(RUNTIME|LIBRARY|ARCHIVE)_OUTPUT_(NAME|DIRECTORY)(_<CONFIG>)?\".  "
+     "Failure to follow this rule is not diagnosed and leaves the location "
+     "of the target undefined.");
 
   cm->DefineProperty
     ("LOCATION_<CONFIG>", cmProperty::TARGET,

-----------------------------------------------------------------------

Summary of changes:
 Source/cmTarget.cxx |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
CMake


More information about the Cmake-commits mailing list