[Cmake-commits] CMake branch, next, updated. v2.8.3-1633-g1971ff8

Brad King brad.king at kitware.com
Tue Feb 15 08:52:58 EST 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
       via  1971ff89d3cb44b2dd0361be18f10d8b1198cd8b (commit)
       via  acd8161bad5d2106f176cd464819df5fbedf2ec7 (commit)
      from  236eab5e3732e3bfbf51a8983bb123203fe9dd18 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1971ff89d3cb44b2dd0361be18f10d8b1198cd8b
commit 1971ff89d3cb44b2dd0361be18f10d8b1198cd8b
Merge: 236eab5 acd8161
Author:     Brad King <brad.king at kitware.com>
AuthorDate: Tue Feb 15 08:52:51 2011 -0500
Commit:     CMake Topic Stage <kwrobot at kitware.com>
CommitDate: Tue Feb 15 08:52:51 2011 -0500

    Merge topic 'fix-clang-warnings' into next
    
    acd8161 ccmake: Remove extra parens around comparison


http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=acd8161bad5d2106f176cd464819df5fbedf2ec7
commit acd8161bad5d2106f176cd464819df5fbedf2ec7
Author:     Brad King <brad.king at kitware.com>
AuthorDate: Tue Feb 15 08:46:50 2011 -0500
Commit:     Brad King <brad.king at kitware.com>
CommitDate: Tue Feb 15 08:46:50 2011 -0500

    ccmake: Remove extra parens around comparison
    
    The Clang compiler warns about extra parenthesis in the code
    
      if ((form->curpage == field->page))
          ~              ^             ~
    
    because the idiom is commonly used when an assignment is intended
    instead of a comparison.  Remove the extra enclosing layer.

diff --git a/Source/CursesDialog/form/frm_driver.c b/Source/CursesDialog/form/frm_driver.c
index 03896c2..f234722 100644
--- a/Source/CursesDialog/form/frm_driver.c
+++ b/Source/CursesDialog/form/frm_driver.c
@@ -1086,7 +1086,7 @@ _nc_Synchronize_Options(FIELD *field, Field_Options newopts)
 
       if (form->status & _POSTED)
         {
-          if ((form->curpage == field->page))
+          if (form->curpage == field->page)
             {
               if (changed_opts & O_VISIBLE)
                 {

-----------------------------------------------------------------------

Summary of changes:
 Source/CursesDialog/form/frm_driver.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
CMake


More information about the Cmake-commits mailing list