View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0009778

CMake

public

2009-10-26 13:32

2016-06-10 14:31

Reporter

augiedoggie

Assigned To

Bill Hoffman

Priority

normal

Severity

tweak

Reproducibility

always

Status

closed

Resolution

moved

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0009778: minor changes to platform module for Haiku OS

Description

I have created a patch which changes a couple of minor things in the Haiku platform module.

1) It creates a HAIKU variable to go along with the BEOS variable. Since Haiku is source and binary compatible with BeOS, having it define BEOS is good, but, Haiku offers things that BeOS didn't. Having this variable would make it easier for projects to check for Haiku.

2) It overrides the default compile flags for a 'Release' build to remove the -O3 optimization flag. While Haiku does include both gcc2 and gcc4, the default will remain as gcc2 for at least a year or two. Since gcc2 is notorious for doing bad things with -O3, I think it should changed to -O2 by default. This problem has been known by BeOS developers for a very long time and they always avoid using this flag.

Is the platform module the appropriate place to override this? Or should there be an 'if' statement added to the gcc.cmake module?

Tags

No tags attached.

Attached Files

haiku_module.diff [^] (891 bytes) 2009-10-26 13:32 [Show Content] [Hide Content]

Index: Modules/Platform/Haiku.cmake
===================================================================
RCS file: /cvsroot/CMake/CMake/Modules/Platform/Haiku.cmake,v
retrieving revision 1.4
diff -p -u -r1.4 Haiku.cmake
--- Modules/Platform/Haiku.cmake	30 Sep 2009 12:31:51 -0000	1.4
+++ Modules/Platform/Haiku.cmake	26 Oct 2009 17:19:16 -0000
@@ -1,8 +1,18 @@
 SET(BEOS 1)
+SET(HAIKU 1)
 
 # GCC is the default compiler on Haiku.
 INCLUDE(${CMAKE_ROOT}/Modules/Platform/gcc.cmake)
 
+# Override the default compile flags to remove -O3
+IF(CMAKE_COMPILER_IS_GNUCC)
+  SET (CMAKE_C_FLAGS_RELEASE_INIT "-O2 -DNDEBUG")
+ENDIF(CMAKE_COMPILER_IS_GNUCC)
+
+IF(CMAKE_COMPILER_IS_GNUCXX)
+  SET (CMAKE_CXX_FLAGS_RELEASE_INIT "-O2 -DNDEBUG")
+ENDIF(CMAKE_COMPILER_IS_GNUCXX)
+
 SET(CMAKE_DL_LIBS root be)
 SET(CMAKE_SHARED_LIBRARY_C_FLAGS "-fPIC")
 SET(CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS "-nostart")

Relationships

Notes
(0018241) augiedoggie (reporter) 2009-10-26 13:49	As a side note unrelated to this ticket... Would you like me to create a code cleanup patch for Haiku to remove some things that are no longer needed? The chances that someone would run into a problem with these changes is about 0.001%. Basically it would involve removing the ifdef checks where __BEOS__ and __HAIKU__ are both being tested for. gcc hasn't defined both of these variables for quite some time. Also you could remove the custom code for usleep(Haiku has this function) and the custom dynamic library code(Haiku uses dlopen as the basis for symbol loading). These aren't really hurting anything so it's a matter of whether you would like to remove this stuff or not. In order for someone to be affected by this they would have to check out the old versions of both Haiku and the gcc2 compiler from the Haiku repository, build them, and then try to build cmake with these old versions.

(0041607) Kitware Robot (administrator) 2016-06-10 14:27	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2009-10-26 13:32	augiedoggie	New Issue
2009-10-26 13:32	augiedoggie	File Added: haiku_module.diff
2009-10-26 13:49	augiedoggie	Note Added: 0018241
2010-12-14 16:10	David Cole	Assigned To	=> Bill Hoffman
2010-12-14 16:10	David Cole	Status	new => assigned
2016-06-10 14:27	Kitware Robot	Note Added: 0041607
2016-06-10 14:27	Kitware Robot	Status	assigned => resolved
2016-06-10 14:27	Kitware Robot	Resolution	open => moved
2016-06-10 14:31	Kitware Robot	Status	resolved => closed