View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0009211

CMake

Modules

public

2009-06-26 14:12

2016-06-10 14:30

Reporter

Wayne Stambaugh

Assigned To

Miguel Figueroa

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

moved

Platform

OS Version

Product Version

CMake-2-6

Target Version

Fixed in Version

Summary

0009211: FindwxWidgets.cmake include path order causes manifest build and link errors in VC8.

Description

The version of FindwxWidgets.cmake include in CMake 2.6.4 incorrectly sets the wxWidgets include path order using the windows find method. This causes a manifest compile and link error when building executable files with Visual Studio 2005 (VC8). For more information about this error see the "Manifest" section at http://www.wxart2d.org/moin/WxArt2dInstall. [^] The library include path should be defined before the main include path to prevent this error. I have include a patch (unified diff) against FindwxWidgets.cmake included with CMake 2.6.4.

Tags

No tags attached.

Attached Files

vc8-manifest.patch [^] (1,086 bytes) 2009-06-26 14:12 [Show Content] [Hide Content]

--- /c/Program Files/CMake 2.6/share/cmake-2.6/Modules/FindwxWidgets.cmake	2008-12-31 10:14:24 -0500
+++ /e/src/kicad-trunk/CMakeModules/FindwxWidgets.cmake	2009-06-25 16:19:35 -0400
@@ -546,9 +546,14 @@
           SET(wxWidgets_FOUND FALSE)
         ENDIF(EXISTS ${WX_ROOT_DIR}/include/wx/wx.h)
 
-        # Set wxWidgets lib setup include directory.
+        # Set wxWidgets lib setup include directory before the main include
+        # directory to prevent Visual Studio 2005 manifest build and link
+        # errors.  For more information, see the Manifest section at:
+        #
+        #     http://www.wxart2d.org/moin/WxArt2dInstall
+        #
         IF(EXISTS ${WX_LIB_DIR}/${wxWidgets_CONFIGURATION}/wx/setup.h)
-          LIST(APPEND wxWidgets_INCLUDE_DIRS
+          LIST(INSERT wxWidgets_INCLUDE_DIRS 0
             ${WX_LIB_DIR}/${wxWidgets_CONFIGURATION})
         ELSE(EXISTS ${WX_LIB_DIR}/${wxWidgets_CONFIGURATION}/wx/setup.h)
           DBG_MSG("WXWIDGET_FOUND FALSE because ${WX_LIB_DIR}/${wxWidgets_CONFIGURATION}/wx/setup.h does not exists.")

Relationships

Notes
(0041574) Kitware Robot (administrator) 2016-06-10 14:27	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2009-06-26 14:12	Wayne Stambaugh	New Issue
2009-06-26 14:12	Wayne Stambaugh	File Added: vc8-manifest.patch
2009-07-18 01:43	Philip Lowman	Assigned To	=> Miguel Figueroa
2009-07-18 01:43	Philip Lowman	Status	new => assigned
2009-07-18 01:43	Philip Lowman	Category	CMake => Modules
2016-06-10 14:27	Kitware Robot	Note Added: 0041574
2016-06-10 14:27	Kitware Robot	Status	assigned => resolved
2016-06-10 14:27	Kitware Robot	Resolution	open => moved
2016-06-10 14:30	Kitware Robot	Status	resolved => closed