| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0006212 | CMake | Modules | public | 2008-01-02 21:06 | 2009-09-26 05:11 | ||||
| Reporter | gga | ||||||||
| Assigned To | Alex Neundorf | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0006212: FindRuby.cmake update for 1.9 | ||||||||
| Description | A cleaner and more up to date FindRuby for 1.9. It handles platforms properly and also deals with MSVC compatibility correctly. It also adds and passes RUBY_*_VERSION around flags. | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files |  FindRuby.cmake [^] (6,771 bytes) 2008-01-02 21:06 | ||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0010119) Alex Neundorf (developer) 2008-01-10 16:26 |
Some comments: -can you please post the modification as patch against current cvs ? -TEENY_VERSION is not common, I'd suggest PATCH_VERSION (as used in CMAKE_PATCH_VERSION) -I think searching for both versions 1.8 and 1.9 makes sense, or is there something speaking against this ? -can you try to make the patch as small as possible, i.e. no formatting changes, that makes it easier to integrate Alex |
|
(0017413) Alex Neundorf (developer) 2009-09-13 13:24 |
Please check current cvs HEAD. I took most of the suggestions from your version and incorporated them into the existing file. Please let me know if something's missing. Alex |
|
(0017768) Alex Neundorf (developer) 2009-09-26 05:11 |
I think the support for 1.9 is good now. Feel free to reopen if something is missing. Alex |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2008-01-02 21:06 | gga | New Issue | |
| 2008-01-02 21:06 | gga | File Added: FindRuby.cmake | |
| 2008-01-03 05:16 | Alex Neundorf | Assigned To | => Alex Neundorf |
| 2008-01-03 05:16 | Alex Neundorf | Status | new => assigned |
| 2008-01-03 05:16 | Alex Neundorf | Category | CCMake => Modules |
| 2008-01-10 16:26 | Alex Neundorf | Note Added: 0010119 | |
| 2009-09-13 13:24 | Alex Neundorf | Note Added: 0017413 | |
| 2009-09-26 05:11 | Alex Neundorf | Note Added: 0017768 | |
| 2009-09-26 05:11 | Alex Neundorf | Status | assigned => closed |
| 2009-09-26 05:11 | Alex Neundorf | Resolution | open => fixed |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |