View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003067

CMake

public

2006-03-31 16:42

2006-03-31 18:01

Reporter

Tanner Lovelace

Assigned To

Bill Hoffman

Priority

low

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0003067: Library link definitions not expanded if also using Frameworks

Description

On OS X, when linking against both frameworks and libraries and using find_library to find said frameworks and libraries, link parameters for libraries are not setup correctly if also linking against a framework.

For instance, this depends line in CMakeCache.txt:

//Dependencies for the target
kdecore_LIB_DEPENDS:STATIC=/opt/qt4/lib/QtCore.framework;-lpthread;/opt/qt4/lib/Qt3Support.framework;/opt/qt4/lib/QtGui.framework;DCOP;/usr/lib/libz.dylib;-framework Carbon;resolv;/fink/lib/libbz2.dylib;dl;

gets translated to this link line:

cd /Users/lovelace/src/kdelibs-build2/kdecore && /usr/bin/c++ -fno-common -O2 -g -dynamiclib -headerpad_max_install_names -single_module -multiply_defined suppress -o ../lib/libkdecore.dylib.5.0.0 -install_name /Users/lovelace/src/kdelibs-build2/lib/libkdecore.dylib.5 $(kdecore_OBJECTS) $(kdecore_EXTERNAL_OBJECTS) -L/Users/lovelace/src/kdelibs-build2/lib -L/Users/lovelace/src/kdelibs-build2/lib/. -L/usr/local/lib -F/opt/qt4/lib -framework QtCore -lpthread -framework Qt3Support -framework QtGui -lDCOP -framework Carbon -lresolv -ldl -framework QtCore -lpthread

Note that none of the dependent libraries have been added to the link line.

I have attached a patch to correct this behavior.

Tags

No tags attached.

Attached Files

cmake-framework-library.patch [^] (913 bytes) 1969-12-31 19:00 [Show Content] [Hide Content]

Index: Source/cmOrderLinkDirectories.cxx
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/cmOrderLinkDirectories.cxx,v
retrieving revision 1.23
diff -u -p -r1.23 cmOrderLinkDirectories.cxx
--- Source/cmOrderLinkDirectories.cxx	16 Mar 2006 16:27:56 -0000	1.23
+++ Source/cmOrderLinkDirectories.cxx	31 Mar 2006 21:33:59 -0000
@@ -258,11 +258,11 @@ bool cmOrderLinkDirectories::DetermineLi
   cmStdString dir;
   cmStdString file;
   std::vector<cmStdString> empty;
-  bool framework = false;
   // do not add a -F for the system frameworks
   this->EmittedFrameworkPaths.insert("/System/Library/Frameworks");
   for(unsigned int i=0; i < this->RawLinkItems.size(); ++i)
     {
+    bool framework = false;
     if(cmSystemTools::FileIsFullPath(this->RawLinkItems[i].c_str()))
       {
       if(cmSystemTools::FileIsDirectory(this->RawLinkItems[i].c_str()))

Relationships

Notes
(0003941) Bill Hoffman (manager) 2006-03-31 18:01	fixed in cvs, thanks!

Issue History
Date Modified	Username	Field	Change