View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002846CMakeCPackpublic2006-02-07 12:292006-03-07 10:02
ReporterDavid Cole 
Assigned ToSystem Admin 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0002846: CPack should not install msvc/mfc dlls for me
DescriptionThese files:
02/07/2006 12:19 PM 1,060,864 mfc71.dll
02/07/2006 12:19 PM 499,712 msvcp71.dll
02/07/2006 12:19 PM 348,160 msvcr71.dll

...are not needed by my application. So CPack should not force them to be included in my installation.

These files should be part of the "make install" tree for whatever projects need them. I build my project with static linking of the C runtime (and I would for MFC, too, if I used it) and so do not need these dlls here.
TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0003815)
David Cole (manager)
2006-02-28 10:41

This whole <snip /> section from CPack.cmake is only needed by CMake's installation program. It is not generally needed by all things built via Visual Studio. These dll's should be installed by CMake's "make install" as appropriate. Then, if the files exist in the install tree, they'll be picked up automatically by CPack...

I shouldn't have to set a variable to avoid installing files that I don't even depend on in the first place... At the very least, CMake should be able to analyze the build settings/output and determine if these files are necessary automatically.


<snip>
# Hack for Visual Studio support
# Search for system runtime libraries based on the platform. This is
# not complete because it is used only for the release process by the
# developers.
IF(NOT CPACK_DISABLE_EXTRA_MSVC_LIBRARIES)
  IF(MSVC)
    STRING(REGEX REPLACE "\\\\" "/" SYSTEMROOT "$ENV{SYSTEMROOT}")
    FOREACH(lib
        "${SYSTEMROOT}/system32/mfc71.dll"
        "${SYSTEMROOT}/system32/msvcp71.dll"
        "${SYSTEMROOT}/system32/msvcr71.dll"
        )
      IF(EXISTS ${lib})
        SET(CMake_INSTALL_SYSTEM_RUNTIME_LIBS
          ${CMake_INSTALL_SYSTEM_RUNTIME_LIBS} ${lib})
      ENDIF(EXISTS ${lib})
    ENDFOREACH(lib)
  ENDIF(MSVC)
ENDIF(NOT CPACK_DISABLE_EXTRA_MSVC_LIBRARIES)

# Include system runtime libraries in the installation if any are
# specified by CMake_INSTALL_SYSTEM_RUNTIME_LIBS.
IF(CMake_INSTALL_SYSTEM_RUNTIME_LIBS)
  IF(WIN32)
    INSTALL_PROGRAMS(/bin ${CMake_INSTALL_SYSTEM_RUNTIME_LIBS})
  ELSE(WIN32)
    INSTALL_PROGRAMS(/lib ${CMake_INSTALL_SYSTEM_RUNTIME_LIBS})
  ENDIF(WIN32)
ENDIF(CMake_INSTALL_SYSTEM_RUNTIME_LIBS)
</snip>

(0003845)
System Admin (reporter)
2006-03-07 10:02

Ok, moved to a separate module

 Issue History
Date Modified Username Field Change


Copyright © 2000 - 2018 MantisBT Team