View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000259CMakepublic2003-10-07 10:092003-11-11 11:43
ReporterAmitha Perera 
Assigned ToBrad King 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0000259: CMake does not quote correctly in DartTestfile.txt
DescriptionPROJECT(p)
ENABLE_TESTING()
SET( X "\"A quoted string\"" )
ADD_TEST( test test ${X} )

results in a DartTestfile.txt with

ADD_TEST(test test ""A quoted string"")

Clearly, the quoting in the generated file is incorrect. This is important when a pathname with spaces is passed as a command-line argument.

(Bug also present in version 1.6)
TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0000211)
Brad King (manager)
2003-10-30 14:35

The argument to SET should have a backslash escaping each of the innter double-quotes. However, doing this still results in an incorrect DartTestfile. This problem will be investigated further.
(0000221)
Brad King (manager)
2003-11-03 15:20

Fixed in CVS:

Checking in cmAddTestCommand.cxx;
/cvsroot/CMake/CMake/Source/cmAddTestCommand.cxx,v <-- cmAddTestCommand.cxx
new revision: 1.19; previous revision: 1.18
done

Fix should be merged to 1.8 branch after corresponding ctest fix is made. Dart's parser should already handle the escaped format.
(0000222)
System Admin (reporter)
2003-11-03 15:38

The CTest part is fixed here:

Checking in Source/cmCTest.cxx;
/cvsroot/CMake/CMake/Source/cmCTest.cxx,v <-- cmCTest.cxx
new revision: 1.63; previous revision: 1.62
done
Checking in Source/cmCTest.h;
/cvsroot/CMake/CMake/Source/cmCTest.h,v <-- cmCTest.h
new revision: 1.18; previous revision: 1.17
done
(0000226)
Brad King (manager)
2003-11-04 08:51

Changing the fix slightly to be more consistent with previous behavior of backslash escaping:

Checking in cmAddTestCommand.cxx;
/cvsroot/CMake/CMake/Source/cmAddTestCommand.cxx,v <-- cmAddTestCommand.cxx
new revision: 1.20; previous revision: 1.19
done
(0000237)
Brad King (manager)
2003-11-05 10:46

Additional fix in CVS:

Checking in cmCTest.cxx;
/cvsroot/CMake/CMake/Source/cmCTest.cxx,v <-- cmCTest.cxx
new revision: 1.65; previous revision: 1.64
done
(0000246)
Brad King (manager)
2003-11-11 11:43

Fixes have been merged to 1.8 branch for 1.8.2 release.

 Issue History
Date Modified Username Field Change


Copyright © 2000 - 2018 MantisBT Team