View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002584

CMake

public

2005-12-10 01:34

2005-12-12 11:34

Reporter

Christopher Lux

Assigned To

Bill Hoffman

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0002584: empty SOURCE_GROUP with filled subgroup are ignored

Description

if a SOURCE_GROUP has no files attached, but has a sub group with attached files, the whole group is ignored and left out of the sln file. for example:

SOURCE_GROUP(source_files/console FILES ${core_console_SRC} ${core_console_HDR})
SOURCE_GROUP(source_files/filesystem FILES ${core_filesystem_SRC})

i also found the bug and did an fix for a local checkout. the fix is as follows:

cmLocalVisualStudio7Generator.cxx:

line 1019 in cmLocalVisualStudio7Generator::WriteGroup(...)

change // If the group is empty, don't write it at all.
if(sourceFiles.empty())
{
return;
}

with this

// If the group is empty, don't write it at all.
if(sourceFiles.empty() && sg->GetGroupChildren().empty())
{
return;
}

please build this into the new releases.

Tags

No tags attached.

Attached Files

Relationships

Notes
(0003390) Christopher Lux (reporter) 2005-12-10 02:03	i have to add, that i use the following before the group definitions: SET(SOURCE_GROUP_DELIMITER "/")

(0003397) Bill Hoffman (manager) 2005-12-12 11:34	fixed in cvs.

Issue History
Date Modified	Username	Field	Change