View Issue Details [ Jump to Notes ] | [ Print ] |
ID | Project | Category | View Status | Date Submitted | Last Update |
0002534 | CMake | CMake | public | 2005-11-28 16:28 | 2005-12-13 15:20 |
|
Reporter | Alex Neundorf | |
Assigned To | Ken Martin | |
Priority | low | Severity | feature | Reproducibility | always |
Status | closed | Resolution | fixed | |
Platform | | OS | | OS Version | |
Product Version | | |
Target Version | | Fixed in Version | | |
|
Summary | 0002534: CMAKE_TARGET_DIR_PREFIX has become a misfeature |
Description | Some months ago support for the CMAKE_TARGET_DIR_PREFIX was added to cmake. Now that cmake puts all its files under CMakeFiles/, IMO it's not required anymore and just a now-useless feature. Additionally it doesn't work completely as one would expect, since the the CMakeFiles/ directory is created additionally. So I'd vote for removing this feature again, as long as nobody really used it. |
Tags | No tags attached. |
|
Attached Files | no_CMAKE_TARGET_DIR_PREFIX.patch [^] (1,853 bytes) 1969-12-31 19:00 [Show Content] [Hide Content]Index: Source/cmLocalUnixMakefileGenerator3.cxx
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/cmLocalUnixMakefileGenerator3.cxx,v
retrieving revision 1.87
diff -b -u -p -r1.87 cmLocalUnixMakefileGenerator3.cxx
--- Source/cmLocalUnixMakefileGenerator3.cxx 17 Nov 2005 18:49:09 -0000 1.87
+++ Source/cmLocalUnixMakefileGenerator3.cxx 28 Nov 2005 21:33:57 -0000
@@ -1980,16 +1980,7 @@ cmLocalUnixMakefileGenerator3
std::string
cmLocalUnixMakefileGenerator3::GetTargetDirectory(cmTarget& target)
{
- std::string dir;
- // Put a prefix on the name if one is given by the CMake code.
- if(const char* prefix = m_Makefile->GetDefinition("CMAKE_TARGET_DIR_PREFIX"))
- {
- dir += prefix;
- }
- else
- {
- dir = "CMakeFiles/";
- }
+ std::string dir = "CMakeFiles/";
dir += target.GetName();
dir += ".dir";
return dir;
Index: Source/cmLocalVisualStudio7Generator.cxx
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/cmLocalVisualStudio7Generator.cxx,v
retrieving revision 1.96
diff -b -u -p -r1.96 cmLocalVisualStudio7Generator.cxx
--- Source/cmLocalVisualStudio7Generator.cxx 22 Nov 2005 18:37:42 -0000 1.96
+++ Source/cmLocalVisualStudio7Generator.cxx 28 Nov 2005 21:33:57 -0000
@@ -1434,13 +1434,7 @@ void cmLocalVisualStudio7Generator::Conf
//----------------------------------------------------------------------------
std::string cmLocalVisualStudio7Generator::GetTargetDirectory(cmTarget& target)
{
- std::string dir;
- // Put a prefix on the name if one is given by the CMake code.
- if(const char* prefix = m_Makefile->GetDefinition("CMAKE_TARGET_DIR_PREFIX"))
- {
- dir = prefix;
- }
- dir += target.GetName();
+ std::string dir = target.GetName();
dir += ".dir";
return dir;
}
|
|