(0037837)
Nils Gladitz (developer)
2015-01-27 10:18

In the meantime you can work around the issue by directly using the underlying COMPILE_DEFINITIONS directory property (which supports generator expressions).

(0037874)
Stephen Kelly (developer)
2015-02-01 11:59

I avoided adding genex support to this command so far for fear of the -D required at the beginning of entries. Content like

add_definitions($<1:-DFOO>)

can not be just added to the COMPILE_DEFINITIONS property, which expects no -D prefix. The prefix would have to be processed and removed at generate time.

Resolving this issue will probably require designing the future for that command. Maybe it shouldn't require/accept the -D? I don't know, and haven't designed anything, but anyone else is welcome to.

(0037878)
raspy (reporter)
2015-02-02 04:07

I think that this command should follow the semantics of target_compile_definitions. At least it should not take -D when using generator expressions, this would make it consistent with other uses target_compile_definitions.

Since passing other options through add_definitions is not encouraged in favor of use add_compile_options, CMake could perhaps make use of a new policy to only allow definitions (without prefixes). As an alternative it could also assume that any argument not starting with a hyphen or a slash is actually a definition, so that:

add_definitions(-DFOO)

and

add_definitions(FOO)

mean the same. This would make easier to introduce syntax:

add_definitions($<1:FOO>)

without further implications of stripping -D prefix.

(0037885)
Brad King (manager)
2015-02-03 09:48

We could also consider creating a new "add_compile_definitions" command to supersede add_definitions for maintaining the directory-level COMPILE_DEFINITIONS property.

(0042704)
Kitware Robot (administrator)
2016-06-10 14:29

Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2015-01-27 10:14	raspy	New Issue
2015-01-27 10:18	Nils Gladitz	Note Added: 0037837
2015-02-01 11:59	Stephen Kelly	Note Added: 0037874
2015-02-02 04:07	raspy	Note Added: 0037878
2015-02-03 09:48	Brad King	Note Added: 0037885
2016-06-10 14:29	Kitware Robot	Note Added: 0042704
2016-06-10 14:29	Kitware Robot	Status	new => resolved
2016-06-10 14:29	Kitware Robot	Resolution	open => moved
2016-06-10 14:29	Kitware Robot	Assigned To	=> Kitware Robot
2016-06-10 14:31	Kitware Robot	Status	resolved => closed

Notes
(0037837) Nils Gladitz (developer) 2015-01-27 10:18	In the meantime you can work around the issue by directly using the underlying COMPILE_DEFINITIONS directory property (which supports generator expressions).

(0037874) Stephen Kelly (developer) 2015-02-01 11:59	I avoided adding genex support to this command so far for fear of the -D required at the beginning of entries. Content like add_definitions($<1:-DFOO>) can not be just added to the COMPILE_DEFINITIONS property, which expects no -D prefix. The prefix would have to be processed and removed at generate time. Resolving this issue will probably require designing the future for that command. Maybe it shouldn't require/accept the -D? I don't know, and haven't designed anything, but anyone else is welcome to.

(0037878) raspy (reporter) 2015-02-02 04:07	I think that this command should follow the semantics of target_compile_definitions. At least it should not take -D when using generator expressions, this would make it consistent with other uses target_compile_definitions. Since passing other options through add_definitions is not encouraged in favor of use add_compile_options, CMake could perhaps make use of a new policy to only allow definitions (without prefixes). As an alternative it could also assume that any argument not starting with a hyphen or a slash is actually a definition, so that: add_definitions(-DFOO) and add_definitions(FOO) mean the same. This would make easier to introduce syntax: add_definitions($<1:FOO>) without further implications of stripping -D prefix.

(0037885) Brad King (manager) 2015-02-03 09:48	We could also consider creating a new "add_compile_definitions" command to supersede add_definitions for maintaining the directory-level COMPILE_DEFINITIONS property.

(0042704) Kitware Robot (administrator) 2016-06-10 14:29	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Relationships