View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0014578

CMake

CPack

public

2013-11-18 04:19

2016-06-10 14:31

Reporter

Bjoern Thiel

Assigned To

Eric NOULARD

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

moved

Platform

OS Version

Product Version

CMake 2.8.12

Target Version

Fixed in Version

Summary

0014578: More consistent paths for CPACK_NSIS_CREATE_ICONS_EXTRA and CPACK_NSIS_DELETE_ICONS_EXTRA

Description

To get more consistent paths for CPACK_NSIS_CREATE_ICONS_EXTRA and CPACK_NSIS_DELETE_ICONS_EXTRA e.g.
  set( CPACK_NSIS_CREATE_ICONS_EXTRA "
    CreateShortCut \\
      \"$SMPROGRAMS\\$STARTMENU_FOLDER\\@PROJECT_NAME@.lnk\" \\
      \"$INSTDIR\\bin\\${architecture}\\@PROJECT_NAME@.exe\"" )
  set( CPACK_NSIS_DELETE_ICONS_EXTRA "
    Delete \"$SMPROGRAMS\\$STARTMENU_FOLDER\\@PROJECT_NAME@.lnk\"
I suggest to cleanup NSIS.template.in.
Otherwise the second has to be
  set( CPACK_NSIS_DELETE_ICONS_EXTRA "
    Delete \"$SMPROGRAMS\\$START_MENU\\@PROJECT_NAME@.lnk\"

Tags

No tags attached.

Attached Files

NSIS.template.in.patch [^] (1,403 bytes) 2013-11-18 04:19 [Show Content] [Hide Content]

diff --git "a/C:\\Users\\bthiel\\AppData\\Local\\Temp\\TortoiseGit\\NSIFF19.tmp\\NSIS.template-e099a37-left.in" "b/D:\\Sources\\cmake\\Modules\\NSIS.template.in"
index 76310af..b089719 100644
--- "a/C:\\Users\\bthiel\\AppData\\Local\\Temp\\TortoiseGit\\NSIFF19.tmp\\NSIS.template-e099a37-left.in"
+++ "b/D:\\Sources\\cmake\\Modules\\NSIS.template.in"
@@ -13,7 +13,6 @@
   Var MUI_TEMP
   Var STARTMENU_FOLDER
   Var SV_ALLUSERS
-  Var START_MENU
   Var DO_NOT_ADD_TO_PATH
   Var ADD_TO_PATH_ALL_USERS
   Var ADD_TO_PATH_CURRENT_USER
@@ -807,9 +806,9 @@ FunctionEnd
 ;Uninstaller Section
 
 Section "Uninstall"
-  ReadRegStr $START_MENU SHCTX \
+  ReadRegStr $STARTMENU_FOLDER SHCTX \
    "Software\Microsoft\Windows\CurrentVersion\Uninstall\@CPACK_PACKAGE_INSTALL_REGISTRY_KEY@" "StartMenu"
-  ;MessageBox MB_OK "Start menu is in: $START_MENU"
+  ;MessageBox MB_OK "Start menu is in: $STARTMENU_FOLDER"
   ReadRegStr $DO_NOT_ADD_TO_PATH SHCTX \
     "Software\Microsoft\Windows\CurrentVersion\Uninstall\@CPACK_PACKAGE_INSTALL_REGISTRY_KEY@" "DoNotAddToPath"
   ReadRegStr $ADD_TO_PATH_ALL_USERS SHCTX \
@@ -867,7 +866,7 @@ Section "Uninstall"
 
   ; If the user changed the shortcut, then untinstall may not work. This should
   ; try to fix it.
-  StrCpy $MUI_TEMP "$START_MENU"
+  StrCpy $MUI_TEMP "$STARTMENU_FOLDER"
   Delete "$SMPROGRAMS\$MUI_TEMP\Uninstall.lnk"
 @CPACK_NSIS_DELETE_ICONS_EXTRA@

Relationships

Notes
(0042426) Kitware Robot (administrator) 2016-06-10 14:29	Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2013-11-18 04:19	Bjoern Thiel	New Issue
2013-11-18 04:19	Bjoern Thiel	File Added: NSIS.template.in.patch
2013-11-18 08:37	Brad King	Assigned To	=> Eric NOULARD
2013-11-18 08:37	Brad King	Status	new => assigned
2016-06-10 14:29	Kitware Robot	Note Added: 0042426
2016-06-10 14:29	Kitware Robot	Status	assigned => resolved
2016-06-10 14:29	Kitware Robot	Resolution	open => moved
2016-06-10 14:31	Kitware Robot	Status	resolved => closed