Attached Files | 0001-BUG-Fix-user-table-function-confusion.patch [^] (2,156 bytes) 2013-08-06 06:07 [Show Content] [Hide Content]From 2f3057e76543a8845460a91a523b627e0ac5e5e8 Mon Sep 17 00:00:00 2001
From: Igor Murzov <igor.murzov@transas.com>
Date: Mon, 5 Aug 2013 18:00:53 +0400
Subject: [PATCH] BUG: Fix "user" table/function confusion
In SQL `user` is a special function that returns name of the current
DB user (and it's called without parentheses). So if one want to
perform query using table "user", he must quote it to avoid confusion.
This commit fixes following error:
ERROR: syntax error at or near "user" at character 8
STATEMENT: UPDATE user SET cookiekey='zJvOEcR9XDDkECqHzYsckQenSIMILcvaM' WHERE id=1
---
login.php | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/login.php b/login.php
index b96a03c..664fd45 100644
--- a/login.php
+++ b/login.php
@@ -84,7 +84,7 @@ function databaseAuthenticate($email,$password,$SessionCachePolicy,$rememberme)
setcookie($cookiename,$value, $time);
// Update the user key
- pdo_query("UPDATE user SET cookiekey='".$key."' WHERE id=".qnum($user_array['id']));
+ pdo_query("UPDATE ".qid("user")." SET cookiekey='".$key."' WHERE id=".qnum($user_array['id']));
}
session_name("CDash");
@@ -220,7 +220,7 @@ function ldapAuthenticate($email,$password,$SessionCachePolicy,$rememberme)
setcookie($cookiename,$value, $time);
// Update the user key
- pdo_query("UPDATE user SET cookiekey='".$key."' WHERE id=".qnum($userid));
+ pdo_query("UPDATE ".qid("user")." SET cookiekey='".$key."' WHERE id=".qnum($userid));
}
session_name("CDash");
@@ -324,7 +324,7 @@ function auth($SessionCachePolicy='private_no_expire')
$db = pdo_connect("$CDASH_DB_HOST", "$CDASH_DB_LOGIN","$CDASH_DB_PASS");
pdo_select_db("$CDASH_DB_NAME",$db);
- pdo_query("UPDATE user SET cookiekey='' WHERE id=".qnum($cookieuseridkey));
+ pdo_query("UPDATE ".qid("user")." SET cookiekey='' WHERE id=".qnum($cookieuseridkey));
setcookie ("CDash-".$_SERVER['SERVER_NAME'], "", time() - 3600);
}
echo "<script language=\"javascript\">window.location='index.php'</script>";
--
1.7.9.5
|