| View Issue Details [ Jump to Notes ] | [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0013879 | CDash | (No Category) | public | 2013-01-25 08:44 | 2014-08-04 09:19 |
|
| Reporter | trsystran | |
| Assigned To | | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | new | Resolution | open | |
| Platform | apache - php 5.3 | OS | | OS Version | |
| Product Version | 2.0 | |
| Target Version | | Fixed in Version | | |
|
| Summary | 0013879: [PATCH] Improve redmine repository viewer links (no revision) |
| Description | get_redmine_diff_url() is called by get_diff_url() which can be called with an empty revision.
However get_redmine_diff_url() does not generate valid redmine urls when the revision is not set.
This patch returns in such case an url pointing to the history of the file (as it seems to be done in get_viewcvs_diff_url() (I'm not sure of that)).
It is at least visible at cdash/viewBuildError.php?buildid=42 where there is a link to the file containing the error.
Ideally we would have here the revision associated with the build, and thus could give a link to the correct version of the file. But I haven't found a way to get the revision on viewBuildError.php. |
| Tags | No tags attached. |
|
| Attached Files |  redmine_diff_url.patch [^] (572 bytes) 2013-01-25 08:44 [Show Content] [Hide Content]--- cdash/repository.php 2013-01-25 14:35:33.596261239 +0100
+++ cdash/repository.php.new 2013-01-25 14:36:48.607028721 +0100
@@ -455,7 +455,15 @@
/** Return the Redmine diff URL */
function get_redmine_diff_url($projecturl, $directory, $file, $revision)
{
- $diff_url = $projecturl . "/revisions/" . $revision . "/diff/";
+ $diff_url = $projecturl;
+ if($revision)
+ {
+ $diff_url .= "/revisions/" . $revision . "/diff/";
+ }
+ else
+ {
+ $diff_url .= "/changes/";
+ }
if($directory)
{
$diff_url .= $directory . "/";
|
|