View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0013733 | Bender | Armatures module | public | 2012-11-23 22:20 | 2013-04-02 14:28 | ||||
Reporter | Julien Finet | ||||||||
Assigned To | johan andruejol | ||||||||
Priority | low | Severity | text | Reproducibility | N/A | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | 1.0 | Fixed in Version | 0.1 | ||||||
Summary | 0013733: Code style suggestions | ||||||||
Description | Rename AddedBone, RemovedBone, ReparentedBone: https://github.com/vovythevov/Bender/commit/93e3f1b6cba352e28fc4881d62d880bb2bc50973#commitcomment-2199926 [^] Don't use representation type but clone a representation: https://github.com/vovythevov/Bender/commit/4514ec4b38495de335763a5b01d6e9864caf8d51#commitcomment-2199931 [^] Armature widget state enum values: https://github.com/vovythevov/Bender/commit/4514ec4b38495de335763a5b01d6e9864caf8d51#commitcomment-2199933 [^] LineSelected = HeadSelected && TailSelected: https://github.com/vovythevov/Bender/commit/476e9a5f62ff0ee5c817daf2352bb6cac466d0cd#commitcomment-2199941 [^] | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | |||||||||
Relationships | |
Relationships |
Notes | |
(0031718) johan andruejol (developer) 2012-11-26 16:21 |
In vtkBoneWidget: Rename AddedBone, RemovedBone, ReparentedBone: https://github.com/vovythevov/Bender/commit/c7df4f662d135340b9125ac91570fc665e32eedc [^] Don't use representation type but clone a representation: https://github.com/vovythevov/Bender/commit/e69d5a68d064fc7e21311b3492fa02c8397ab2ef [^] https://github.com/vovythevov/Bender/commit/e84e004475ab69d697fd06979bfbbc3cd3d0aa66 [^] Armature widget state enum values: https://github.com/vovythevov/Bender/commit/9fa0f4b07a08c6a020a470c368e88a39b19047fe [^] In Armature: Armature widget state enum values: https://github.com/vovythevov/Bender/commit/296c49f2800c28083b6bd5feaa4237891ecc7edd [^] Don't use representation type but clone a representation: https://github.com/vovythevov/Bender/commit/4a0e00fe177f1ce0ac48663589490dfd25e91f63 [^] |
(0031728) johan andruejol (developer) 2012-11-27 10:25 |
Don't use representation type but clone a representation: The copy is a DeepCopy and not a ShallowCopy. Either the name should be changed or the code should really perform a ShallowCopy. |
(0031733) johan andruejol (developer) 2012-11-27 18:06 |
Fix Always on Top due to the representation clone: https://github.com/vovythevov/Bender/commit/9619cc1a6389918465f1aeb1ba5ac0bd9cf9fd28 [^] https://github.com/vovythevov/Bender/commit/84efea6d927513f20bb963ac8322eabbd5547584 [^] |
(0031748) johan andruejol (developer) 2012-11-28 13:45 |
Don't use representation type but clone a representation: https://github.com/vovythevov/Bender/commit/18d4d5df2d294b85211584e330bf7d1e8533b30b [^] |
(0031766) johan andruejol (developer) 2012-11-29 15:39 edited on: 2012-11-29 15:42 |
Use appropriate method name: https://github.com/vovythevov/Bender/commit/ab34494eba149e66c4c1df50a9e54bbf88740e3f [^] |
(0031768) johan andruejol (developer) 2012-11-29 15:48 |
Enforce Representation: https://github.com/vovythevov/Bender/commit/5b2c67d7533b9e371310ade01dfb8f7a397d4a48 [^] |
(0031846) johan andruejol (developer) 2012-12-06 14:17 |
I don't think this issue applies anymore in the light of the refactoring occurring in 13610. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2012-11-23 22:20 | Julien Finet | New Issue | |
2012-11-23 22:20 | Julien Finet | Status | new => assigned |
2012-11-23 22:20 | Julien Finet | Assigned To | => johan andruejol |
2012-11-26 16:21 | johan andruejol | Note Added: 0031718 | |
2012-11-27 10:25 | johan andruejol | Note Added: 0031728 | |
2012-11-27 18:06 | johan andruejol | Note Added: 0031733 | |
2012-11-28 13:45 | johan andruejol | Note Added: 0031748 | |
2012-11-29 15:39 | johan andruejol | Note Added: 0031766 | |
2012-11-29 15:42 | johan andruejol | Note Edited: 0031766 | |
2012-11-29 15:48 | johan andruejol | Note Added: 0031768 | |
2012-12-06 14:17 | johan andruejol | Note Added: 0031846 | |
2012-12-06 14:17 | johan andruejol | Status | assigned => resolved |
2012-12-06 14:17 | johan andruejol | Resolution | open => fixed |
2013-01-17 17:53 | Julien Finet | Fixed in Version | => 0.1 |
2013-02-14 14:35 | Julien Finet | Status | resolved => closed |
2013-04-02 14:28 | Julien Finet | Target Version | => 1.0 |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |