View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013270CMakeModulespublic2012-06-05 04:052012-08-09 19:36
Reporterraspy 
Assigned ToAlex Neundorf 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
Platformx86_64OSLinuxOS VersionRHEL 5
Product VersionCMake 2.8.8 
Target VersionCMake 2.8.9Fixed in VersionCMake 2.8.9 
Summary0013270: Remove "temporary" debug message for ASM compiler id
DescriptionThis is regarding commit 9071b8b87f0e63f10f1f77949246c1b4241cfb6c.

Please remove this "temporary" message. After over a year in code it is no longer temporary and its output is confusing users and is pure garbage in build log. We use TI assembler so it barfs out many times before it is detected.

Please also do not put such "temporary" "debug" messages in official release builds. It is confusing users and builders.
Steps To ReproduceSet CMAKE_C_COMPILER in a toolchain file to cl6x and then set CMAKE_ASM_COMPILER to ${CMAKE_C_COMPILER}. Upon ASM configuration it barfs out all kind of compiler versions and usages.
Additional InformationCommit 4b40d4297aa7b984e9b5fa905cdee21960ec4f8a changed behavior for assembler (which I consider a breaking change when connected to this faulty commit 9071b8b87f0e63f10f1f77949246c1b4241cfb6c).

In cmake 2.8.8 (and 2.8.6 at least, but probably somewhere around 2.8.4/5) when CMAKE_ASM_COMPILER is not set it is taken from CMAKE_C_COMPILER (this is 4b40d4297aa7b984e9b5fa905cdee21960ec4f8a - a good thing). This is the only way to avoid this faulty behavior of 9071b8b87f0e63f10f1f77949246c1b4241cfb6c and to keep output silent when detecting ASM compiler id, so I need to remove setting CMAKE_ASM_COMPILER(_INIT)? from toolchain file. This however will no longer work with cmake 2.8.3 which does not have behavior from 4b40d4297aa7b984e9b5fa905cdee21960ec4f8a and it default to /usr/bin/as in such situation.
TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0029671)
Alex Neundorf (developer)
2012-06-12 16:31
edited on: 2012-06-12 16:31

Thanks for pointing this out, this must have been left in accidentially.
Removed and merged into next.

If you have another problem with cl6x now, please open a separate bug report for this.

Thanks
Alex


 Issue History
Date Modified Username Field Change
2012-06-05 04:05 raspy New Issue
2012-06-05 08:39 Brad King Assigned To => Alex Neundorf
2012-06-05 08:39 Brad King Status new => assigned
2012-06-12 16:31 Alex Neundorf Note Added: 0029671
2012-06-12 16:31 Alex Neundorf Resolution open => fixed
2012-06-12 16:31 Alex Neundorf Category (No Category) => Modules
2012-06-12 16:31 Alex Neundorf Note Edited: 0029671
2012-06-12 16:32 Alex Neundorf Status assigned => closed
2012-08-09 19:36 David Cole Fixed in Version => CMake 2.8.9
2012-08-09 19:36 David Cole Target Version => CMake 2.8.9


Copyright © 2000 - 2018 MantisBT Team