View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0012915CMakeModulespublic2012-01-27 09:432012-09-03 16:02
ReporterLaurent Rineau 
Assigned ToClinton Stimpson 
PrioritylowSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake 2.8.6 
Target VersionCMake 2.8.8Fixed in VersionCMake 2.8.8 
Summary0012915: Bad wording in FindQt4.cmake
DescriptionIn Modules/FindQt4.cmake, one can read:

"Warning: But QtCore couldn't be found. Qt must NOT be installed correctly, or it wasn't found for cross compiling."

Really, Qt must NOT be installed correctly?! :-)
That wording is simply wrong. I propose "Qt is NOT installed correctly."

I attached the Git patch.
TagsNo tags attached.
Attached Filespatch file icon cmake-FindQt4.patch [^] (790 bytes) 2012-01-27 09:43 [Show Content]

 Relationships

  Notes
(0028416)
Brad King (manager)
2012-01-27 11:40

Clinton, should the relevant message command be converted to use message(WARNING) along with the wording correction? Something like (untested):

MESSAGE(WARNING
  "QT_QMAKE_EXECUTABLE reported QT_INSTALL_LIBS as ${QT_LIBRARY_DIR_TMP} "
  "but QtCore could not be found there.  "
  "Qt is NOT installed correctly for the target build environment."
  )
(0028534)
Clinton Stimpson (developer)
2012-02-08 20:42

cbdfcc6 FindQt4: clarify warning message about incorrect Qt installation.
(0030876)
David Cole (manager)
2012-09-03 16:02

Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2012-01-27 09:43 Laurent Rineau New Issue
2012-01-27 09:43 Laurent Rineau File Added: cmake-FindQt4.patch
2012-01-27 11:37 Brad King Assigned To => Clinton Stimpson
2012-01-27 11:37 Brad King Status new => assigned
2012-01-27 11:40 Brad King Note Added: 0028416
2012-02-08 20:42 Clinton Stimpson Note Added: 0028534
2012-02-08 20:42 Clinton Stimpson Status assigned => resolved
2012-02-08 20:42 Clinton Stimpson Resolution open => fixed
2012-04-19 15:45 David Cole Fixed in Version => CMake 2.8.8
2012-04-19 15:45 David Cole Target Version => CMake 2.8.8
2012-09-03 16:02 David Cole Note Added: 0030876
2012-09-03 16:02 David Cole Status resolved => closed


Copyright © 2000 - 2018 MantisBT Team