View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001100

CMake

public

2004-08-19 07:49

2005-02-17 10:52

Reporter

tom d

Assigned To

Brad King

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0001100: small patch to fix the (annoying) make warnings: 'Circular ... dependency dropped'

Description

problem:
if EXECUTABLE_OUTPUT_PATH is a relative path, then cmake adds an additional
empty dependency to the Makefile
${TARGET} : ${TARGET_WITH_RELATIVE_PATH}

the problem is though that if the relative path is "." then the Makefile
contains a circular dependency. This leads to make warning
about this while compiling, all the time.

solution:
the easiest fix is to do an easy string test to see if target and
dependfile are the same

to do this one adds a single line near the end of the method
cmLocalUnixMakefileGenerator::OutputExecutableRule in the
file cmLocalUnixMakefileGenerator.cxx, approx. line 1534

above the last call of this->OutputMakeRulethis->OutputMakeRule(...)
add the line: if("./"+target!=depend)

effect:
the last call of this->OutputMakeRule does not create the Makefile entries
if they are circular.
(it's not 100% proof since I could also have a longer relative path leading
to "." also but it fixes 99% of the cases...)

Tags

No tags attached.

Attached Files

Relationships

Notes
(0002051) Brad King (manager) 2005-02-10 08:23	Fixed in CVS version: /cvsroot/CMake/CMake/Source/cmLocalUnixMakefileGenerator.cxx,v <-- cmLocalUnixMakefileGenerator.cxx new revision: 1.196; previous revision: 1.195 Basically using a relative path for an output path should be expanded by CMake into a path relative to each build directory.

Issue History
Date Modified	Username	Field	Change