MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0009516CMakeCMakepublic2009-09-09 17:092009-09-17 15:34
Reporterdataangel 
Assigned ToBrad King 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-6 
Target VersionFixed in Version 
Summary0009516: CHECK_COMPILER_FLAG and CHECK_CXX_COMPILER_FLAG won't detect unrecognized options with GCC
DescriptionGCC still returns a 0 (success) error code when given an unrecognized option. In order to detect if GCC didn't accept the flag, in addition to checking the exit code the resulting output text must be searched for "unrecognized option".
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0012394closed Brad King Check compiler flags for Clang 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-09-09 17:09dataangelNew Issue
2009-09-11 17:05Bill HoffmanStatusnew => assigned
2009-09-11 17:05Bill HoffmanAssigned To => Brad King
2009-09-17 15:33Brad KingNote Added: 0017595
2009-09-17 15:34Brad KingStatusassigned => closed
2009-09-17 15:34Brad KingResolutionopen => fixed
2011-08-08 12:54Brad KingRelationship addedrelated to 0012394

Notes
(0017595)
Brad King   
2009-09-17 15:33   
The commits below address this issue and add a test to make sure it works on other compilers too.

Cleanup generic compiler check macro documentation
/cvsroot/CMake/CMake/Modules/CheckCCompilerFlag.cmake,v <-- Modules/CheckCCompilerFlag.cmake
new revision: 1.3; previous revision: 1.2
/cvsroot/CMake/CMake/Modules/CheckCSourceCompiles.cmake,v <-- Modules/CheckCSourceCompiles.cmake
new revision: 1.19; previous revision: 1.18
/cvsroot/CMake/CMake/Modules/CheckCSourceRuns.cmake,v <-- Modules/CheckCSourceRuns.cmake
new revision: 1.12; previous revision: 1.11
/cvsroot/CMake/CMake/Modules/CheckCXXCompilerFlag.cmake,v <-- Modules/CheckCXXCompilerFlag.cmake
new revision: 1.2; previous revision: 1.1
/cvsroot/CMake/CMake/Modules/CheckCXXSourceCompiles.cmake,v <-- Modules/CheckCXXSourceCompiles.cmake
new revision: 1.16; previous revision: 1.15
/cvsroot/CMake/CMake/Modules/CheckCXXSourceRuns.cmake,v <-- Modules/CheckCXXSourceRuns.cmake
new revision: 1.8; previous revision: 1.7

Add FAIL_REGEX to CHECK_(C|CXX)_SOURCE_COMPILES
/cvsroot/CMake/CMake/Modules/CheckCSourceCompiles.cmake,v <-- Modules/CheckCSourceCompiles.cmake
new revision: 1.20; previous revision: 1.19
/cvsroot/CMake/CMake/Modules/CheckCXXSourceCompiles.cmake,v <-- Modules/CheckCXXSourceCompiles.cmake
new revision: 1.17; previous revision: 1.16

Fix CHECK_(C|CXX)_COMPILER_FLAG for GNU and MSVC
/cvsroot/CMake/CMake/Modules/CheckCCompilerFlag.cmake,v <-- Modules/CheckCCompilerFlag.cmake
new revision: 1.4; previous revision: 1.3
/cvsroot/CMake/CMake/Modules/CheckCXXCompilerFlag.cmake,v <-- Modules/CheckCXXCompilerFlag.cmake
new revision: 1.3; previous revision: 1.2

Test CHECK_(C|CXX)_COMPILER_FLAG macros
/cvsroot/CMake/CMake/Tests/TryCompile/CMakeLists.txt,v <-- Tests/TryCompile/CMakeLists.txt
new revision: 1.17; previous revision: 1.16