MantisBT - CDash
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0007736CDashpublic2008-09-25 10:062009-03-28 17:18
ReporterDan Thill 
Assigned ToJulien Jomier 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformWin32OSXPOS Version
Product Version 
Target VersionFixed in Version1.4 
Summary0007736: Root directory in websvn URL must have trailing slash for websvn paths to be generated correctly
DescriptionWhen setting the CVS/SVN Viewer URL, if a root is specified, it must have a trailing slash and ampersand, e.g:

pc-dthill2/websvn/listing.php?repname=Chronos&path=trunk/&


For example, if the trailing slash is omitted:

pc-dthill2/websvn/listing.php?repname=Chronos&path=trunk&


When get_websvn_diff_url() generates a URL for the file, it will not add the trailing slash, so the path is messed up:

pc-dthill2/websvn/listing.php?repname=Chronos&path=trunkApplication/src/File.cpp&

Steps To Reproduce
Additional InformationWhen defining the CVS/SVN Viewer URL, a trailing ampersand must be present, or the root isn't detected properly (common.php:2320). Maybe this should be documented?
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-09-25 10:06Dan ThillNew Issue
2008-09-25 10:10Dan ThillNote Added: 0013578
2009-02-03 12:48Julien JomierStatusnew => assigned
2009-02-03 12:48Julien JomierAssigned To => Julien Jomier
2009-02-03 12:53Julien JomierNote Added: 0014765
2009-02-03 12:53Julien JomierStatusassigned => resolved
2009-02-03 12:53Julien JomierFixed in Version => 1.4
2009-02-03 12:53Julien JomierResolutionopen => fixed
2009-03-28 17:18Julien JomierStatusresolved => closed

Notes
(0013578)
Dan Thill   
2008-09-25 10:10   
Please ignore the "Additional Information" about the trailing ampersand. I misread the code.
(0014765)
Julien Jomier   
2009-02-03 12:53   
Looks like it was a bug in the parsing of the URL. You should only need to put:
 pc-dthill2/websvn/listing.php?repname=Chronos&path=trunk