MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0007191CMakeQtDialogpublic2008-06-14 13:152009-10-06 13:36
ReporterAlex Neundorf 
Assigned ToClinton Stimpson 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-6 
Target VersionFixed in Version 
Summary0007191: improvements for the "Compiler setup" dialog
DescriptionHi,

the new "Compiler setup" dialog is nice :-)
But there are some things which could be improved IMO:

-when the dialog opens, "Use defaults" is selected. This is ok, but the dialog is big and most of it is empty then. This looks strange. I don't have a good idea how to improve it.

-all input fields should have a tooltip which shows the name of the CMake variable which it represents

-"Compiler setup":
--I think using a VBoxLayout would look better than a grid
--it is unclear what happens if you don't enter anything in the line edits (I tried, nothing happens). As it is now, one could get the impression that you have to enter all three compilers (including Fortran). Maybe each one should have an enable-checkbox ?
--it should have a "what's this" help saying something like "if you want to explicitely specify the compilers which will be used by cmake, enter them here, with the full path"

-"Cross Compiler Setup"
--the "Use Toolchain File" checkbox is strange. Maybe this should be split into two, so there would be 4 radio buttons ?
* Use Defaults
* Compiler Setup
* Manual Cross Compiler Setup
* Cross Compiler Setup using a Toolchain file
-if "Use Toolchain File" is disabled:
--same comments as for the "Compiler Setup" widget
--maybe the "Compilers" box should be at the top, so it looks more similar to the "Compiler Setup" widget ?

"System" box:
-I think "Target System" would be a better name
-"Name" is the name of the operating system of the target system, so maybe
 "Operating System" would be better (and the tooltip showing "CMAKE_SYSTEM_NAME"
-the field "Name" could have a file selector, which starts in cmake/Modules/Platforms/, and if e.g. Linux.cmake is selected, NAME_WE is inserted (i.e. "Linux")
-the "Version" and the "Processor" are very optional, this should be marked somehow

"Find Program/Library/Include" box:
-"Root" is the Root directory of the target environment, so maybe better "Target Environment Root Dir" or "Target Root Dir" or at least "Target Root" ?
-for "Program" the default should be "Don't find from Root"
-for the other two the default should be "Only find from Root"
-the entries in the combo boxes should be renamed to
-- "Search in Target Root, then native system"
-- "Search only in Target Root"
-- "Search only in native system"

Alex
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-06-14 13:15Alex NeundorfNew Issue
2008-06-14 13:15Alex NeundorfStatusnew => assigned
2008-06-14 13:15Alex NeundorfAssigned To => Clinton Stimpson
2008-11-04 18:51Clinton StimpsonNote Added: 0014029
2008-12-18 09:39Clinton StimpsonNote Added: 0014396
2009-01-07 17:33Clinton StimpsonNote Added: 0014483
2009-01-07 17:33Clinton StimpsonStatusassigned => resolved
2009-01-07 17:33Clinton StimpsonResolutionopen => fixed
2009-10-06 13:36Alex NeundorfNote Added: 0017975
2009-10-06 13:36Alex NeundorfStatusresolved => closed

Notes
(0014029)
Clinton Stimpson   
2008-11-04 18:51   
How would a wizard like approach be? Then we can spread these out on multiple pages as well as have a detailed description on each page of what the user can set. Its probably just a couple extra clicks if you're doing cross-compiling or have specific compilers you want to use.
(0014396)
Clinton Stimpson   
2008-12-18 09:39   
Alex, can you try out the new stuff I committed?
It should address most of these issues.
(0014483)
Clinton Stimpson   
2009-01-07 17:33   
Marking resolved.
If there are more issues, I guess a separate bug report specifically for that issue will suffice.
(0017975)
Alex Neundorf   
2009-10-06 13:36   
Clinton marked it as resolved already.