MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0004057CMakeCMakepublic2006-11-22 02:482007-08-24 14:22
ReporterSoeren Textor 
Assigned ToAlex Neundorf 
PriorityurgentSeveritymajorReproducibilityunable to reproduce
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0004057: SOURCE_GROUP - problem with subfolders with same same
DescriptionHi there's szll a bug within SOURCE_GROUP and subfolders (even at the cvs version):

Example:

DIRS ON HDD:
\world
\world\europe
\world\europe\france\people
\world\europe\france\paris
\world\europe\france\paris\people


CMAKELIST.TXT:
SOURCE_GROUP(world a.cpp)
SOURCE_GROUP(world\\europe b.cpp)
SOURCE_GROUP(world\\europe\\france\\people c.cpp) SOURCE_GROUP(\\world\\europe\\france\\paris d.cpp) SOURCE_GROUP(world\\europe\\france\\paris\\people e.cpp)

WHAT WE GET IN VS8.0:
\world - a.cpp
\world\europe b.cpp
\world\europe\france\people c.cpp e.cpp <--- !!!! error \world\europe\france\paris d.cpp

We are missing:
\world\europe\france\paris\people

It seems that it's not possible to have two subdirs with the same name branch. Every file of folders with same name will be put to the "upperst" folder...

best regards,
SirAnn
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch SourceGroup.patch (7,976) 1969-12-31 19:00
https://public.kitware.com/Bug/file/1047/SourceGroup.patch
patch SourceGroup-fixed-tokenizer.patch (8,695) 1969-12-31 19:00
https://public.kitware.com/Bug/file/1083/SourceGroup-fixed-tokenizer.patch
Issue History
Date ModifiedUsernameFieldChange
2007-08-24 10:18Alex NeundorfNote Added: 0008646
2007-08-24 11:04Thomas ArcilaNote Added: 0008651
2007-08-24 14:22Alex NeundorfNote Added: 0008658
2007-08-24 14:22Alex NeundorfAssigned ToBill Hoffman => Alex Neundorf
2007-08-24 14:22Alex NeundorfStatusassigned => closed
2007-08-24 14:22Alex NeundorfResolutionunable to reproduce => fixed

Notes
(0007967)
Thomas Arcila   
2007-07-01 02:21   
Here is a fix attempt to source_group handling of subgroup. Not heavily tested but it works for me.
Please test it and report.

It fixes systematic recursion when looking for a child when first components of the group name doesn't match.
(0008646)
Alex Neundorf   
2007-08-24 10:18   
The tokenizer patch fixes the case where just "\\" is used for the sourcegroup name, right ?
(0008651)
Thomas Arcila   
2007-08-24 11:04   
Yes. IIRC it is used to return a vector containing an empty string (the previous version used to return a empty vector)
(0008658)
Alex Neundorf   
2007-08-24 14:22   
Patch looks good, applied to cvs HEAD.

Alex